Better Rails 3.0 compatibility #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sice latest 3.0 Rails version (Rails 3.0.17) depends on erubis ~> 2.6.6, it is not usable with better_errors gem now.
|
Thanks for the contribution! I'm inclined to merge this in immediately, but @charliesome may be more familiar as to why 2.7+ was needed in the first place. |
|
👍 |
haileys
pushed a commit
that referenced
this pull request
Dec 30, 2012
Better Rails 3.0 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since latest 3.0 Rails version (Rails 3.0.17) depends on erubis ~> 2.6.6, it is not usable with better_errors gem now.
I tried erubis 2.6.6 locally with my big Rails 3.0.17 project without problems with custom better_errors gemspec. I tried some travis tests also - https://travis-ci.org/simi/better_errors/builds/3803034. I'm new into better_errors, so I'm not sure if those JRuby and RBX tests are allowed to fail now. But those errors are same for erubis 2.7.0 and erubis 2.6.6.
Happy Christmas and thank you for this nice gem.