Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use default connect sequences when custom connect sequences added #685

Closed
bpringe opened this issue Jul 22, 2020 · 1 comment
Closed

Comments

@bpringe
Copy link
Member

bpringe commented Jul 22, 2020

Two problems here really:

  1. For my project I wanted to add some code to be run after the clojure cli repl is started. So I added a custom replConnectSequence for this with afterCLJReplJackInCode. This works fine, except that when I start my shadow-cljs repl in a separate terminal and try to connect, I only get the option "Clojure CLI." I see that if any custom replConnectSequences are provided, only those are presented, but it would be nice if I could select/use the default shadow-cljs connect sequence, along with my custom Clojure CLI connect sequence.

  2. So this lead me to try to create a custom sequence for shadow-cljs, but alas, I cannot make it work correctly because the default shadow sequence has an object for cljsType.connectCode and the JSON schema for the replConnectSequences says it must be a string.

image

Maybe it's not meant for the end-user to add an object themselves, and is only meant to be used as an object in Calva's default connect sequences?

In any case, so long as I have custom repl connect sequences, It seems I am prevented from connecting to a shadow-cljs repl in a way that allows me to evaluate code in it.

@PEZ
Copy link
Collaborator

PEZ commented Jul 22, 2020 via email

@bpringe bpringe changed the title Cannot add custom repl sequence for shadow-cljs Cannot use default sequences when one custom sequence added Jul 23, 2020
@bpringe bpringe changed the title Cannot use default sequences when one custom sequence added Cannot use default connect sequences when custom connect sequences added Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants