Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output window sometimes getting out of synch, needing overwrite #699

Closed
PEZ opened this issue Jul 29, 2020 · 5 comments
Closed

Output window sometimes getting out of synch, needing overwrite #699

PEZ opened this issue Jul 29, 2020 · 5 comments
Labels
bug Something isn't working output/repl window

Comments

@PEZ
Copy link
Collaborator

PEZ commented Jul 29, 2020

The output window sometimes gets out of synch with what's saved on disk. This causes it to behave strangely at times, and also annoys the user with a message about wether to revert it from disk or overwriting.

@PEZ PEZ added bug Something isn't working output/repl window labels Jul 29, 2020
@PEZ
Copy link
Collaborator Author

PEZ commented Jul 29, 2020

I know why this is happening, and I also think I know how to fix it.

Then again, I have thought I have fixed it several times now. ¯\(ツ)

@bpringe
Copy link
Member

bpringe commented Jul 29, 2020

Do we have a solid repro case? I can't repro. =/

@bpringe
Copy link
Member

bpringe commented Jul 29, 2020

microsoft/vscode#7025 Related I think. I did have this happen to me again since my last comment, and have been trying to reproduce.

@bpringe
Copy link
Member

bpringe commented Jul 29, 2020

microsoft/vscode#66035 (comment)
There is a setting to always overwrite for a given folder. I'm not sure if it can be set by Calva though, for the .calva folder.

@PEZ
Copy link
Collaborator Author

PEZ commented Jul 29, 2020

No solid repro. It happens now and then. But now I have fixed it by writing the greetings text using the workspace edit API, same as we are updating the window with, so we should get no more conflicts like this once the PR is released.

@PEZ PEZ closed this as completed in 004628f Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working output/repl window
Projects
None yet
Development

No branches or pull requests

2 participants