Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parinfer experiments #1377

Merged
merged 22 commits into from
Nov 10, 2021
Merged

Parinfer experiments #1377

merged 22 commits into from
Nov 10, 2021

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Nov 8, 2021

What has Changed?

I'm experimenting with inserting a combo of Parinfer's infer parens and using the formatter for keeping lists being pushed forward by typing formatted.

This is what it looks like right now. (There are some more quirks than is showing here. Too tired to write much more right now.)

calva-parinfer-and-format-forward

This is as WIP as it can be. Not sure it is going to work well enough for actual usage, actually. However, the changes should be pretty safe behind these two settings, so maybe we can bring it out to users to test soon, and let that guide us in wether we should continue with the feature.

Fixes #253

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.

Ping @PEZ, @bpringe

@PEZ PEZ merged commit 018b1d0 into dev Nov 10, 2021
@PEZ PEZ deleted the pez/253-parinfer-experiments branch November 10, 2021 13:02
@PEZ PEZ mentioned this pull request Nov 13, 2021
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant