Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code formatting #8

Merged
merged 1 commit into from
Nov 4, 2021
Merged

code formatting #8

merged 1 commit into from
Nov 4, 2021

Conversation

haesleinhuepf
Copy link
Member

Description

Hi Johannes @jo-mueller ,

this is just code style stuff and minor comment corrections. Could you please configure your editor that it helps you doing these things automatically, e.g. numpy-style comments?

Feel free to merge it right away if you're happy with the modifications.

Type of change

  • Bug-fix
  • New feature
  • Breaking change
  • Documentation update

References

Tests

  • I adapted existing tests, because
  • I added new tests to cover the code change
  • All tests pass with my change

Final checks

  • My change is the minimal possible work for the desired feature/fix
  • I updated the documentation where necessary to cover the change

line break by end of file
numpy-style
empty lines
@jo-mueller
Copy link
Contributor

Spyder suggests the following as a docstring template:

def test(parameter_a:int, parameter_b:float, parameter_c=False):
    """
    DESCRIPTION

    Parameters
    ----------
    parameter_a : int
        DESCRIPTION.
    parameter_b : float
        DESCRIPTION.
    parameter_c : TYPE, optional
        DESCRIPTION. The default is False.

    Returns
    -------
    parameter_a : TYPE
        DESCRIPTION.

    """
    
    
    return parameter_a

Is this suitable?

@haesleinhuepf
Copy link
Member Author

Is this suitable?

Yes, that looks great

@jo-mueller jo-mueller merged commit 8d876ea into main Nov 4, 2021
@jo-mueller jo-mueller deleted the code-format branch November 4, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants