Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular mapping configuration #162

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Modular mapping configuration #162

merged 2 commits into from
Jan 12, 2022

Conversation

sdecoodt
Copy link
Contributor

@sdecoodt sdecoodt commented Nov 3, 2021

Hi,

I saw there was an open discussion on having the concept of "Mapping Profiles" in Sieve.
In our project we are currently using lightweight extensions to the current fluent API, inspired by the EF Core EnityTypeConfigurations to split our mapping configurations in modules.

I think it would be a nice addition to the library that will not impact existing users.

The impact to the library is kept focused in the ISieveConfiguration.cs
I extended the mapping unit tests to run with 3 types of processors.

  • "As is" mapping configuration in the processor
  • Explicit mapper module configuration
  • Scanned module configuration.

README.md was also updated with possible usage scenarios

Kind regards,
Steven

@jochenjonc
Copy link

@Biarity @a-patel @hasanmanzak I think this PR would be a good addition to Sieve. What is blocking this PR and how can I help?

Copy link
Collaborator

@hasanmanzak hasanmanzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry about the late response. I'm extremely overwhelmed by work stuff. 😤 🤷

@hasanmanzak hasanmanzak merged commit 863d75b into Biarity:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants