Allow Filters on different sources to share the same name #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows Posts and Comments to both use the IsNew filter with their own implementations.
zolrath
force-pushed
the
Allow-Same-Filter-Name
branch
from
9e37706
to
d792813
Compare
Biarity
approved these changes
Jun 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to make a custom search filter that was shared across multiple models I found that once a specific filter name was used multiple times that filter would fail.
The
GetMethodreflection call didn't take into account the actual type of the results.It now searches specifically for the required method of the correct type and will search more generally if this fails to be able to throw the
IncompatibleMethodException.In the tests this allows
PostsandCommentsto both use theIsNewfilter with their own implementations.