Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_retries is not applied #12

Closed
radokristof opened this issue Mar 27, 2024 · 6 comments
Closed

max_retries is not applied #12

radokristof opened this issue Mar 27, 2024 · 6 comments

Comments

@radokristof
Copy link

I have a default configuration for AutoKuma:

AUTOKUMA__KUMA__DEFAULT_SETTINGS: >-
docker.docker_container: {{container_name}}
http.max_redirects: 10
http.max_retries: 2

But the max_retries is not applied, all monitor has 0 retry. I have tried setting the same on an individual monitor as well, same issue.

@BigBoot
Copy link
Owner

BigBoot commented Mar 28, 2024

Oh looks like this is an error in the readme, can you try the following (the settings have to be separated by a newline):

AUTOKUMA__KUMA__DEFAULT_SETTINGS: |-
  docker.docker_container: {{container_name}}
  http.max_redirects: 10
  http.max_retries: 2

@radokristof
Copy link
Author

Thank you, I will test this. Anyway, I have tried setting the max_retries on a particular monitor as well, it did not work.
I assume all configuration changes should be picked up by AutoKuma, even if that is an already created monitor, right?

@BigBoot
Copy link
Owner

BigBoot commented Mar 28, 2024

That is correct, as long as it's a monitor managed by AutoKuma.

@radokristof
Copy link
Author

radokristof commented Mar 28, 2024

Unfortunately, same. I did not try creating a new one, but already created did not get updated, "retries" stays at 0.
It seems that this is not particularly a problem with the default settings. I have tried settings max_retries on a monitor as well, like kuma.monitor.http.max_retries: 2 but still it is not getting populated.

@BigBoot
Copy link
Owner

BigBoot commented Mar 31, 2024

Turns out uptime kuma calls these maxredirects/maxretries so the automatic camelCase to snake_case conversion didn't work for them, I've added manual aliases so they should work now.

@radokristof
Copy link
Author

@BigBoot thank you for your help! It is working now correctly. I also had to fix env key as others described in: #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants