Fix number inputs disappearing when empty. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbadal
commented
Dec 18, 2022
| @@ -19,7 +19,7 @@ export default () => ({ | |||
| </div> | |||
| <div className='divider' /> | |||
| {vnode.attrs.config.map((val) => { | |||
| if (!Types[val.type] || !vnode.attrs.value[val.key]) { | |||
| if (!Types[val.type]) { | |||
There was a problem hiding this comment.
If there was a specific reason for adding this, we should probably check undefined or another value rather than the falsiness of the value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces NaN with an empty string. The best approach would be to add a validation step before updating the template with invalid values, but until then. its probably better to not have fields disappearing 😅