Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Validation action to PR and main branch #23

Merged
merged 6 commits into from
Dec 21, 2022
Merged

Conversation

nbadal
Copy link
Contributor

@nbadal nbadal commented Dec 18, 2022

This workflow automatically lints and builds the frontend + backend to ensure PRs and commits are mergeworthy 😁

image

Note: Also explicitly use HTTPS for NPM, as it doesn't require an SSH key.
I found this useful when testing the action with act for example

@BigJk
Copy link
Owner

BigJk commented Dec 19, 2022

Thanks. Seems useful! I never worked with Github Actions so far. What kind of response would I get if I tried to push commits that result in a linting error? Will this affect all new pushs to master?

@nbadal
Copy link
Contributor Author

nbadal commented Dec 19, 2022

@BigJk GitHub Actions are so nice 😁 Definitely nice to have a "set it and forget it" set of checks to help reduce manual steps.

Unless you have specific branch protections enabled, it shouldn't reject any commits. If a push to master included a lint error, it would simply fail the pipeline and put a ❌ in the UI. No functional difference, just a visual indicator.

Additionally, if you desire, you can enable a setting that requires Pull Requests to pass certain checks before merging. Again, no effect on repository owners though, and you can also override the check as an owner as well.

@BigJk BigJk merged commit 7ab9db1 into BigJk:master Dec 21, 2022
@nbadal nbadal deleted the actions branch December 23, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants