Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add addresses encoding decoding #32

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Feat/add addresses encoding decoding #32

merged 3 commits into from
Apr 26, 2024

Conversation

AngelCastilloB
Copy link
Member

Description

Add address encoding and decoding for all CIP-019 address formats:

  • Byron Address
  • Base Address
  • Enterprise Address
  • Pointer Address
  • Reward Address

Checklist

  • I have read followed CONTRIBUTING.md
    • I have added tests
    • I have updated the documentation
    • I have updated the CHANGELOG
  • Are there any breaking changes?
    • If yes: I have marked them in the CHANGELOG
  • Does this PR introduce any platform specific code?
  • Security: Does this PR potentially affect security?
  • Performance: Does this PR potentially affect performance?

@AngelCastilloB AngelCastilloB force-pushed the feat/add-addresses-encoding-decoding branch 2 times, most recently from a005b18 to 2436a1c Compare April 25, 2024 05:43
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@AngelCastilloB AngelCastilloB force-pushed the feat/add-addresses-encoding-decoding branch 6 times, most recently from 0d31206 to b579e0d Compare April 26, 2024 10:03
@AngelCastilloB AngelCastilloB force-pushed the feat/add-addresses-encoding-decoding branch 2 times, most recently from eab4d0d to 968b1e1 Compare April 26, 2024 10:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

MISRA C Logo

MISRA Guideline Compliance Summary

Commit: 8a533e7d9722b5cb579fb8d35ff11f67df9d3805
Date: 2024-04-26
Guidelines: MISRA C 2012
Checking Tool: Cppcheck
Result: Compliant ✅

🎉 No MISRA C 2012 Violations Found!

You can download the complete report from: MISRA C Report

@AngelCastilloB AngelCastilloB force-pushed the feat/add-addresses-encoding-decoding branch from 968b1e1 to 2e8c4de Compare April 26, 2024 10:19
@AngelCastilloB AngelCastilloB force-pushed the feat/add-addresses-encoding-decoding branch from 2e8c4de to 2b470de Compare April 26, 2024 13:22
luisdbianchi
luisdbianchi approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@luisdbianchi luisdbianchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AngelCastilloB AngelCastilloB merged commit c631f14 into main Apr 26, 2024
7 checks passed
@AngelCastilloB AngelCastilloB deleted the feat/add-addresses-encoding-decoding branch April 26, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisdbianchi luisdbianchi luisdbianchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AngelCastilloB @luisdbianchi