-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook for automatic package generation #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. A couple of inline comments of a general nature.
now we have tests, can we set up CI in the cookiecutter repo itself? Also a pre-commit check?
@@ -1,8 +1,9 @@ | |||
{ | |||
"full_name": "Name or Organization", | |||
"project_name": "MyProject", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not have caps/camelcase, so "myproject", but we could also use "diffpy.myproject" to remind people that they can use "a.b.project" pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or "my-project"
@@ -1,8 +1,9 @@ | |||
{ | |||
"full_name": "Name or Organization", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is asking for org, why don't we call the key "org_name"? or will that break things too much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to touch these names, but I can open a new issue addressing the names in the .json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added another comment
@@ -1,8 +1,9 @@ | |||
{ | |||
"full_name": "Name or Organization", | |||
"project_name": "MyProject", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or "my-project"
I think there is a pre-commit check already for the cookiecutter repo. Does running |
I have it running locally (run `pre-commit install`) but it didn't run in
CI on the PR
…On Wed, Jun 19, 2024 at 3:28 PM Sparky ***@***.***> wrote:
this looks good to me. A couple of inline comments of a general nature.
now we have tests, can we set up CI in the cookiecutter repo itself? Also
a pre-commit check?
I think there is a pre-commit check already for the cookiecutter repo.
Does running pre-commit . in the root of this repo start it up?
—
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUIR6NJGOQ6PB2S5ADDZIHLV3AVCNFSM6AAAAABJSIFNQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGM2TIMZYGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Simon Billinge
Professor,
Department of Applied Physics and Applied Mathematics
Columbia University
|
Behavior: when user enters a package
a.b.c
this will create the following directory structure:When only a package name
c
is given, the structure is simply:The following string is used to create the
__init__.py
files:where
module_name
is the name of the namespace module the__init__.py
is nested in.