Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature Tab squished... #226

Closed
ghost opened this issue Jul 23, 2018 · 10 comments
Closed

Temperature Tab squished... #226

ghost opened this issue Jul 23, 2018 · 10 comments
Labels

Comments

@ghost
Copy link

ghost commented Jul 23, 2018

Set everything up, considering I've only been messing with a pi and linux based stuff for a day or two... only had a couple of brain farts which confused me for a while until I figured it out!

I've spent a good while messing around with various framebuffer/hdmi etc settings to get the best combination I can on the display and webcam etc...

picture 007

picture 006

picture 003

Everything is great except the Temperature Graph and Target Temp display are squished into the top half of the display area, I can't work out if it's something I've messed up due to the way I set the display up or something else?

picture 008

@ghost
Copy link
Author

ghost commented Jul 26, 2018

Ok, I think I've worked out how to add a custom less file...

/home/pi/custom.less

Nothing working though....

Stumped...

@ghost ghost changed the title Tempertaure Tab squished... Temperature Tab squished... Aug 1, 2018
@ghost
Copy link
Author

ghost commented Aug 1, 2018

ok, no idea if I'm doing this right but...

  1. Copied touchui.bundled.less to /home/pi/custom.less
  2. Modified min and max height for #temp and #temperature-graph
  3. Working on getting the canvas/grid, I think its referred as... to sit correctly...

Is this how it's meant to be done or is there another/easier way its supposed to be done?

@ghost
Copy link
Author

ghost commented Aug 1, 2018

Finally figured it out...

picture 016

Although someone on the octoprint forum just explained the @media query to me, I think that was the reason for all the problems in the first place...

Will edit afew lines and see if it was the root cause all along!?!

@CTcartesian3D
Copy link

Nope... definitely something wrong somewhere.... Worked ok then touchui seems to decide it doesn't want to take a blind bit of notice of any settings and goes back to displaying the graph as small and as squished as before!?!

Hope ya back soon Paul... driving me nutz!?!

@CTcartesian3D
Copy link

ok... heres what I got... not sure its the right way... but it seems to be solving the issue.

I'm using @media queries one each for #temp and #temperature-graph...

@media (min-width: 700px) {
height: 390px;
}
@media (min-height: 700px) {
height: 390px;
}

Been reading up on this and it seems to be used alot to query screen resolution widths to determine how things are displayed regarding sizing etc?

320px
414px
703px
768px

Wondering if this method would be a better/cleaner solution than whats there... particularly the min and max heights under #temp ... just a thought I had while reading up on it.

#temp {
margin-left: -@main-gutter;
margin-right: -@main-gutter;
overflow: hidden;
> div:first-child {
.box-sizing(border-box);
overflow: hidden;
width: 100%;
height: 60vh;
max-height: 300px;
min-height: 140px;
@media (min-width: 1000px) {
min-height: 390px;
}
padding: 0 @main-gutter;
margin: 0 0 @main-gutter;
#temperature-graph {
.box-sizing(border-box);
position: relative;
background-position: center 37%;
background-repeat: no-repeat;
background-size: auto 80%;
height: 108%;
max-height: 320px;
width: auto;
margin: 0;
@media (max-height: 400px) {
height: 110%;
}
@media (max-height: 300px) {
height: 112%;
}
@media (min-height: 700px) {
max-height: 390px;
}

Not sure if the placement/values are right but its working... will carry on tinkering with it.

@BillyBlaze
Copy link
Owner

Thanks for reporting and both your workarounds was on the right track.

I have removed all the media queries and set the max-height to none, this way the height: 60vh; can take over and that will always consume 60% of the total viewport.

I will release this in the next version.

@BillyBlaze BillyBlaze added fixed and removed pending labels Sep 1, 2018
@CTcartesian3D
Copy link

I'll try it on mine and see how it goes...

The only way I could get the temp graph (Canvas?) to sit correctly with the temp legends sitting on the outside of the graph correctly was to change the width to auto instead of 100%... Is this still the case or can I put it back to 100%??

@StefanMeGit
Copy link

Is there now any finished function to bring the graph into a nice view on vertical displays? Or at least a proper description how to dow it?

@BillyBlaze
Copy link
Owner

@StefanMeGit

In the latest version it should be responsive on any orientated screen:
image

If it's still to small, then please provide some more info in a new ticket with device/browser.

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants