Skip to content

Boolean Match not triggered when falsy value is sent #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2022
Merged

Boolean Match not triggered when falsy value is sent #456

merged 1 commit into from
Mar 29, 2022

Conversation

arthurkirkosa
Copy link
Collaborator

@arthurkirkosa arthurkirkosa commented Mar 29, 2022 •
edited
Loading

Fixes #453

The problem was with the value for the query param... show_inactive=0 would result in (bool) 0 => false; altho show_inactive param was in query

@arthurkirkosa arthurkirkosa requested a review from binaryk March 29, 2022 11:12
@binaryk binaryk merged commit 68ad473 into 6.x Mar 29, 2022
@binaryk binaryk deleted the arthurkirkosa-patch-1 branch March 29, 2022 11:38
@binaryk
Copy link
Collaborator

binaryk commented Mar 29, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binaryk binaryk binaryk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurkirkosa @binaryk