The current theme only works on 5.2 due to the use of wp_body_open

[ronalfy]

The use of wp_body_open only exists in WordPress 5.2. Creating a PR now to make sure it works in lesser versions unless you want this theme to be 5.2 only.

[BinaryMoon]

Thanks.

I had something similar to this originally (see the code here: https://github.com/BinaryMoon/granule/blob/master/compat.php)

However I removed the compat.php file. I am trying to encourage best practice, and that's to keep WordPress up to date.

Perhaps it's a bit soon though since this function is only a few months old. What do you think?

[ronalfy]

It’s up to you. What version of WP will you be targeting?

On Mon, Jul 8, 2019 at 17:26 Ben Gillbanks ***@***.***> wrote: Thanks. I had something similar to this originally (see the code here: https://github.com/BinaryMoon/granule/blob/master/compat.php) However I removed the compat.php file. I am trying to encourage best practice, and that's to keep WordPress up to date. Perhaps it's a bit soon though since this function is only a few months old. What do you think? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AAE3M2IFUURZSHECS7VDFDTP6O5IFA5CNFSM4H67XB72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZOQZOA#issuecomment-509414584>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE3M2MMPRB3XGFR3RX7T5DP6O5IFANCNFSM4H67XB7Q> .

-- This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error, please notify Ronald Huereca at ronalfy@gmail.com. You can only delay the inevitable. www.ronalfy.com

[BinaryMoon]

The latest version :)

I'm still not 100% sure what to do. At the moment I'm edging towards leave it as is. Since the theme probably won't be on wordpress.org for about 4 months (a month to finish building and 3 months to review) the 5.2 adoption rate should be quite high.

The other option I am considering would be to add back the compat file and add a note for when it can be removed. I'd then have a fallback for any future non-compat functions I might use.

[ronalfy]

I'd say stick with 5.2 then.

[BinaryMoon]

Just been looking at the install stats and I think you're right.
https://wordpress.org/about/stats/

5.2 is only 30% and this is the only feature stopping the theme from being used on other installs. I think I will add back the compat.php with a note about the required version. I can then remove it when the installation rate is better.