Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider removing kmer/sequence type inference from strings in favor of generalized version in BioSequences #31

Open
cjprybol opened this issue Feb 27, 2023 · 0 comments · May be fixed by #35
Open

consider removing kmer/sequence type inference from strings in favor of generalized version in BioSequences #31

cjprybol opened this issue Feb 27, 2023 · 0 comments · May be fixed by #35
Labels
question

Comments

@cjprybol
Copy link
Contributor

See current code at:

Kmers.jl/src/kmer.jl

Line 329 in f7a1328

@inline function Kmer(seq::String)

Rationale at: BioJulia/BioSequences.jl#268 (comment)

and candidate replacement capability at: BioJulia/BioSequences.jl#269
@cjprybol cjprybol changed the title consider removing kmer/sequence type inference from strings in favor of generalized version in BIoSequences consider removing kmer/sequence type inference from strings in favor of generalized version in BioSequences Mar 1, 2023
@jakobnissen jakobnissen linked a pull request Dec 30, 2023 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking changes for v1 jakobnissen/Kmers.jl
2 participants
@cjprybol @kescobo