Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Split file IO into separate package #82

Closed
pdimens opened this issue Jul 28, 2021 · 2 comments
Closed

[feature] Split file IO into separate package #82

pdimens opened this issue Jul 28, 2021 · 2 comments
Labels
breaking This fix/feature would be a breaking change

Comments

@pdimens
Copy link
Collaborator

pdimens commented Jul 28, 2021

Is your feature request related to a problem and which?
Not a problem, but it would be easier to treat file IO as a separate package that is required by and re-exported by PopGen.jl

Benefits

  • Simple maintenance because it will only require basic PopData functions
  • PopGen.jl codebase will be smaller
  • IO development can be independent from other package components
  • Contributions will be independent from main PopGen.jl codebase because it will only feature IO-specific things
  • cool new logo
  • precompile read functions with test data

are there alternatives?
Keep the package monolithic as it is now

additional info
@pdimens pdimens added the enhancement New feature or request label Jul 28, 2021
@pdimens
Copy link
Collaborator Author

pdimens commented Jul 29, 2021 •
edited
Loading

migration has begun on popgenio branch. see PopGenCore.jl.

To do:

  • Register and add PopGenCore as dep
  • reexport PopGenCore
  • remove codebase that was moved into PopGenCore
  • update documentation to reflect changes

@pdimens pdimens mentioned this issue Jul 29, 2021
Closed
@pdimens
Copy link
Collaborator Author

pdimens commented Jul 30, 2021

PopData and Genotype/GenoArray have been moved into PopGenCore.jl

@pdimens pdimens added breaking This fix/feature would be a breaking change and removed enhancement New feature or request labels Aug 3, 2021
@pdimens pdimens closed this as completed Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking This fix/feature would be a breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pdimens