Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508 for collections/admin/specupload.php #694

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

NikitaSalikov
Copy link
Collaborator

@NikitaSalikov NikitaSalikov commented Nov 3, 2023

Changes Made:

  • added doctype and lang attribute
  • added labels
  • removed size from type "file"

Pull Request Checklist:

Pre-Approval

  • There is a description section in the pull request that details what the proposed changes do. It can be very brief if need be, but it ought to exist.
  • [N/A] Hotfixes should be branched off of the master branch and squash and merged back into the master branch.
  • Features and backlog bugs should be merged into the Development branch, NOT master
  • All new text is preferably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages)
  • [N/A] There are no linter errors
  • New features have responsive design (i.e., look aesthetically pleasing both full screen and with small or mobile screens)
  • Symbiota coding standards have been followed
  • [N/A] If any files have been reformatted (e.g., by an autoformatter), the reformat is its own, separate commit in the PR
  • Comment which GitHub issue(s), if any does this PR address
  • [N/A] If this PR makes any changes that would require additional configuration of any Symbiota portals outside of the files tracked in this repository, make sure that those changes are detailed in this document.

Post-Approval

  • It is the code author's responsibility to merge their own pull request after it has been approved
  • If this PR represents a merge into the Development branch, remember to use the squash & merge option
  • If this PR represents a merge from the Development branch into the master branch, remember to use the merge option
  • If this PR represents a hotfix into the master branch, a subsequent PR from master into Development should be made merge option (i.e., no squash).
  • If the dev team has agreed that this PR represents the last PR going into the Development branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock the Development branch to prevent accidental merges while QA takes place. Follow the release protocol here.
  • Don't forget to delete your feature branch upon merge. Ignore this step as required.

Thanks for contributing and keeping it clean!

Copy link
Collaborator

@Atticus29 Atticus29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and TVP is happy!

@NikitaSalikov NikitaSalikov merged commit 857d56c into Development Nov 15, 2023
@NikitaSalikov NikitaSalikov deleted the 508-collections-admin-specupload branch November 15, 2023 16:18
MuchQuak added a commit that referenced this pull request Nov 15, 2023
* misc fixes for map searhc (#712)

* 508 for collections/admin/specuploadmanagement.php (#687)

* added doctype and lang, fixed title accessibility

* add unique id to profile list id radio buttons

* fix ternary operator spacing issues

* fix a few more spacing issues

---------

Co-authored-by: Mark <mark.aaron.fisher@gmail.com>

* Added doctype and lang (#688)

* added doctype and lang (#689)

* 508 for checklists/voucheradmin.php (#686)

* added doctype and lang, fixed stylings, fixed title accessibility

* make minor fix recommended by TVP

---------

Co-authored-by: Mark <mark.aaron.fisher@gmail.com>

* added doctype and lang, added labels, removed size from type file (#694)

* Admin-based editor search button in collection profile quicksearch (#711)

* get the editor search to work

* add i8n for collection profile quick search

* make the occid part of the url for edit click with catalog number. Establish proof of concept for occurId calculation but immediately discover its incorrect current implementation

* add processEditorSearch.php that handles occid fetching server-side and redirects to other urls as needed

* revert submitAndRedirectSearchForm to previous simpler version

* Map sandbox hotfix 11 15 23 (#715)

* Initial lealfet map for checklists

* Finished google refactor, leaflet version, and added intauralist support for project_ids, but only first 200 for now

* attaches proper host in case $SEVER_HOST ins't setup

* Going back to hold host sender for points because red herring problem

* Added uncertainty rendering on profile map

* Adding auto draw modes

* fixing point aid issues

* fixing auto select issues mapcoordaid

---------

Co-authored-by: NikitaSalikov <86389284+NikitaSalikov@users.noreply.github.com>
Co-authored-by: Mark <mark.aaron.fisher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants