Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(inactive) Epicopy #39

Closed
7 tasks done
sean-cho opened this issue Jun 28, 2016 · 52 comments
Closed
7 tasks done

(inactive) Epicopy #39

sean-cho opened this issue Jun 28, 2016 · 52 comments
Assignees
Labels
3b. declined not appropriate for Bioconductor ERROR WARNINGS

Comments

@sean-cho
Copy link

sean-cho commented Jun 28, 2016

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.
  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.
  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.
  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Subversion
    (optionally via GitHub).

For help with submitting your package, please subscribe and post questions
to the bioc-devel mailing list.

@bioc-issue-bot
Copy link
Collaborator

Hi @sean-cho

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: Epicopy
Type: Package
Title: Get CNV information from 450K array
Version: 0.99.0
Date: 2015-02-25
Authors@R: c(
    person('Sean, Soonweng', 'Cho', email = 'sean.cho@jhmi.edu', role = c('aut','cre')),
    person('Hyunseok', 'Kim', email = 'hkim190@jhmi.edu', role = c('aut')),
    person('Leslie', 'Cope', email = 'lcope1@jhmi.edu', role = c('aut')))
Description: Get CNV information from 450K array
License: Artistic License 2.0
Depends:
    Biobase,
    BiocGenerics
Imports:
    RColorBrewer,
    gplots,
    Hmisc,
    minfi,
    GenomicRanges,
    IRanges,
    DNAcopy,
    GenomeInfoDb,
    ParDNAcopy,
    TxDb.Hsapiens.UCSC.hg19.knownGene,
    modeest,
    org.Hs.eg.db
Suggests:
    Gviz,
    knitr,
    rmarkdown,
    EpicopyData
biocViews:
    DNAMethylation, CopyNumberVariation, MethylationArray
VignetteBuilder: knitr
RoxygenNote: 5.0.1

@sean-cho
Copy link
Author

AdditionalPackage: https://github.com/sean-cho/EpicopyData

@bioc-issue-bot
Copy link
Collaborator

Can't build unless issue is open and '2. review in progress' label is present, or issue is closed and 'TESTING' label is present.

@bioc-issue-bot
Copy link
Collaborator

Your package has been approved for building. Your package is
now submitted to our queue.

IMPORTANT: Please read the instructions for setting
up a push hook on your repository, or further changes to your
repository will NOT trigger a new build.

@bioc-issue-bot bioc-issue-bot added 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place and removed 1. awaiting moderation labels Jun 28, 2016
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/Epicopy_buildreport_20160628185900.html

@mtmorgan
Copy link
Contributor

Looks like you submitted the packages in reverse order -- should have started with the package that does not depend on the other. We'll sort this out manually, but probably not until tomorrow morning.

@mtmorgan
Copy link
Contributor

Actually, can you be sure to add a web hoook to EpicopyData and then try to increment the version of EpicopyData to 0.99.1?

@sean-cho
Copy link
Author

Hi Martin, I pushed 0.99.1 to test the webhook. How should I reverse the order on the two packages? Thanks!

@mtmorgan
Copy link
Contributor

mtmorgan commented Jun 29, 2016

OK, can you try posting a comment like the one above,

AdditionalPackage: https://github.com/sean-cho/EpicopyData

@dtenenba
Copy link
Contributor

Actually just post a comment like that in the current issue (#39)

@sean-cho
Copy link
Author

AdditionalPackage: https://github.com/sean-cho/EpicopyData

@bioc-issue-bot
Copy link
Collaborator

Hi @sean-cho,

Starting build on additional package https://github.com/sean-cho/EpicopyData.

IMPORTANT: Please read the instructions for setting up a
push hook on your repository, or further changes to your
additional package repository will NOT trigger a new build.

The DESCRIPTION file of this additional package is:

Package: EpicopyData
Type: Package
Title: Epicopy datasets
Version: 0.99.1
Date: 2015-11-02
Authors@R: c(
person('Sean, Soonweng', 'Cho', email = 'sean.cho@jhmi.edu', role = c('aut','cre')),
person('Hyunseok', 'Kim', email = 'hkim190@jhmi.edu', role = c('aut')),
person('Leslie', 'Cope', email = 'lcope1@jhmi.edu', role = c('aut')))
Maintainer: Sean Cho <sean.cho@jhmi.edu>
Description: Package holding test data and normal data for Epicopy.
License: GPL3
Suggests: 
Epicopy
Imports: 
minfi
biocViews:
DNAMethylation, CopyNumberVariation, MethylationArray

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/EpicopyData_buildreport_20160629155134.html

@mtmorgan
Copy link
Contributor

OK, next issue -- I see that you're using git lfs. The single package builder is not equipped to use lfs, but the right solution is to enable it. Again this will take some work on our end, please be patient.

@mtmorgan
Copy link
Contributor

mtmorgan commented Jul 5, 2016

Can you try to version bump EpicopyData again? git lfs should be enabled across build systems.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push; starting a build. Commits are:

4efc422 v 0.99.2 - LFS push.

@sean-cho
Copy link
Author

sean-cho commented Jul 5, 2016

Just bumped. Thanks for helping me figure this out.

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/EpicopyData_buildreport_20160705184933.html

@mtmorgan
Copy link
Contributor

mtmorgan commented Jul 8, 2016

One last version bump on the data package, removing Epicopy from the Suggests: field

@bioc-issue-bot
Copy link
Collaborator

Received a valid push; starting a build. Commits are:

03b0ec4 V 0.99.3: Remove Epicopy from suggested packages.

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/EpicopyData_buildreport_20160708121616.html

@mtmorgan
Copy link
Contributor

mtmorgan commented Jul 9, 2016

OK, the next steps are up to you -- address the issues in the build report, then bump & commit.

  • The correct notation for the GPL version three is GPL-3. The LICENSE file claims Artistic-2, and this isn't appropriate -- choose one or the other (or some other license); neither GPL-3 nor Artistic-2 require a LICENSE file.
  • Provide a man page for all.normals
  • re-compress the allNormals.rda file -- the saving is substantial
  • subscribe to the bioc-devel mailing list, or if already subscribed align your email address on the mailing list and in the DESCRIPTION file.
  • ExperimentData packages do not require a vignette, but one can be helpful in describing the data presented in a more extended version than on the man page.

@mtmorgan
Copy link
Contributor

If you need help, please let me know. Otherwise, I'll close the issue in a couple of days.

@sean-cho
Copy link
Author

Hi Martin,

Thanks for the feedback and for offering to help. I've made most of the changes you suggested.

I'm trying to understand re-compressing the allNormals.rda. It was saved as a default .gz compressed file. I re-compressed as .bz, but I save a small amount (~17MB). Is this in line with your suggestion, or is there another specific re-compression process you were referring to?

Thanks,
Sean

@mtmorgan
Copy link
Contributor

mtmorgan commented Jul 20, 2016

I followed the suggestion in the build report and did

R CMD build --resave-data EpicopyData

and then extracted the relevant file

tar zxvf EpicopyData_0.99.1.tar.gz EpicopyData/data/allNormals.rda

and then EpicopyData/data/allNormals.rda is 400Mb rather than the original.

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, WARNINGS, ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/Epicopy_buildreport_20160802192656.html

@bioc-issue-bot
Copy link
Collaborator

Received a valid push; starting a build. Commits are:

c85590d 0.99.4: Fix getLRR example.

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, WARNINGS, ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/Epicopy_buildreport_20160802224622.html

@bioc-issue-bot
Copy link
Collaborator

Received a valid push; starting a build. Commits are:

da7088e 0.99.5: Various fixes.

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS, ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/Epicopy_buildreport_20160803182733.html

@bioc-issue-bot
Copy link
Collaborator

Received a valid push; starting a build. Commits are:

9ac2dee 0.99.6: Dependencies.

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/Epicopy_buildreport_20160814111418.html

@sean-cho
Copy link
Author

Hi Martin,

Epicopy is not building because it is looking for EpicopyData -- do you know if I have to bump EpicopyData again?

Thanks,
Sean

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings
on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/EpicopyData_buildreport_20160818163221.html

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, WARNINGS, ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/Epicopy_buildreport_20160818175623.html

@mtmorgan
Copy link
Contributor

Hi -- I triggered a manual build of the EpicopyData and then Epicopy packages. It looks like your package is still far from ready to review. I suggest that you remove the github webhook, close this issue, continue developing your package on your own system, and when it is ready for review create a new issue.

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, WARNINGS, ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/Epicopy_buildreport_20160818184603.html

@mtmorgan mtmorgan added 3b. declined not appropriate for Bioconductor and removed 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place labels Aug 23, 2016
@bioc-issue-bot bioc-issue-bot changed the title Epicopy (inactive) Epicopy Aug 23, 2016
@mtmorgan
Copy link
Contributor

OK I closed the issue; not a big deal, just start another when your package is building without warnings / errors under the 'devel' version of Bioconductor.

@sean-cho
Copy link
Author

Thanks Martin.

@bioc-issue-bot bioc-issue-bot mentioned this issue Feb 27, 2018
8 tasks
@bioc-issue-bot bioc-issue-bot mentioned this issue Apr 13, 2018
@bioc-issue-bot bioc-issue-bot mentioned this issue May 31, 2018
8 tasks
@bioc-issue-bot bioc-issue-bot mentioned this issue Jun 9, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3b. declined not appropriate for Bioconductor ERROR WARNINGS
Projects
None yet
Development

No branches or pull requests

4 participants