-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed contribution task for Outreachy applicants: Link xenTro10 (UCSC genome) to UCB_Xtro_10.0 (NCBI assembly) #48
Comments
Good day sir, please assign me to this task. |
@Simplecodez Don't forget to record your contribution #46 on Outreachy! |
Okay sir. Thank you |
Sir, just created a PR for this task. I will be anticipating your feedback. |
All right @Simplecodez , I merged that (PR #74). Thank you! Did you try to do You can also try |
Thank you sir.
Yes sir, I tried that and it returned the expected result
I will try this now |
I just tried this now and everything works well. |
Perfect ✔️ Next task in your group is issue #56. Whenever you are ready, go there and ask to be assigned. Also don't forget to record your contributions on Outreachy at https://www.outreachy.org/outreachy-december-2022-internship-round/communities/bioconductor/refactor-the-bsgenomeforge-tools/contributions/ |
This task depends on issues #46 and #47 being completed first (i.e. PRs accepted and merged, and issues closed). Although it's not a requirement that the 3 tasks be completed by the same applicant, it will be a more interesting learning experience if they are.
The purpose of "linking" a UCSC genome to the NCBI assembly that it is based on, is to support the
map.NCBI
argument of thegetChromInfoFromUCSC()
function. TrygetChromInfoFromUCSC("hg19", map.NCBI=TRUE)
. See what happens? Now trygetChromInfoFromUCSC("xenTro10", map.NCBI=TRUE)
. See what the problem is? Check the documentation of themap.NCBI
argument in?getChromInfoFromUCSC
to learn more about what this argument does.Linking a UCSC genome to its NCBI assembly is done by defining an
NCBI_LINKER
object in the registration file for the UCSC genome (xenTro10.R
in this case). There's some very succinct information about whatNCBI_LINKER
should look like in theREADME.TXT
file located inGenomeInfoDb/inst/registered/UCSC_genomes/
. Don't hesitate to look at other registration files to see examples of howNCBI_LINKER
is defined.IMPORTANT NOTES TO OUTREACHY APPLICANTS:
R CMD build
andR CMD check
on the package. Note thatR CMD check
should always be run on the source tarball produced byR CMD build
.R CMD check
might produce some NOTEs and even some WARNINGs. These are ok if they existed before your changes. You can check that by taking a look at the daily report produced by our automated builds here: https://bioconductor.org/checkResults/devel/bioc-LATEST/ Make sure to not introduce new NOTEs or WARNINGs!The text was updated successfully, but these errors were encountered: