Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tailwind and all components to match the latest design #259

Merged
merged 5 commits into from
Sep 8, 2021

Conversation

fuxingloh
Copy link
Member

@fuxingloh fuxingloh commented Sep 7, 2021

What kind of PR is this?:

/kind chore

What this PR does / why we need it:

https://www.figma.com/file/XyC92lfHtuASf2IU3o0dho/DeFiScan?node-id=209%3A17982

Developer Checklist:

  • Read your code changes at least once
  • Tested on multiple web browsers
  • Tested responsiveness (e.g, iPhone, iPad, Desktop)
  • No console errors
  • Unit tests*
  • Added e2e tests*

@codeclimate
Copy link

codeclimate bot commented Sep 7, 2021

Code Climate has analyzed commit e7947e3 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Sep 7, 2021

✔️ Deploy Preview for defi-scan ready!

🔨 Explore the source changes: e7947e3

🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-scan/deploys/61379cc11cc99c0007362364

😎 Browse the preview: https://deploy-preview-259--defi-scan.netlify.app/404

@cypress
Copy link

cypress bot commented Sep 7, 2021



Test summary

47 0 0 0


Run details

Project scan
Status Passed
Commit f1a6347 ℹ️
Started Sep 7, 2021 5:11 PM
Ended Sep 7, 2021 5:14 PM
Duration 02:27 💡
OS Linux Ubuntu - 20.04
Browser Chrome 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #259 (e7947e3) into main (6c99353) will increase coverage by 0.21%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   80.21%   80.43%   +0.21%     
==========================================
  Files          49       49              
  Lines         551      557       +6     
  Branches      126      127       +1     
==========================================
+ Hits          442      448       +6     
+ Misses        102      100       -2     
- Partials        7        9       +2     
Impacted Files Coverage Δ
src/components/commons/AdaptiveList.tsx 100.00% <ø> (ø)
src/components/commons/AdaptiveTable.tsx 100.00% <ø> (ø)
src/components/commons/Breadcrumb.tsx 64.28% <ø> (ø)
src/components/commons/CursorPagination.tsx 67.56% <ø> (ø)
src/components/dex/PoolPairs.tsx 71.42% <ø> (ø)
src/components/prices/PriceFeedBySection.tsx 100.00% <ø> (ø)
src/layouts/components/Footer.tsx 100.00% <ø> (ø)
src/pages/blocks/index.tsx 90.90% <ø> (ø)
src/pages/dex/index.tsx 100.00% <ø> (+20.00%) ⬆️
src/pages/prices/index.tsx 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c99353...e7947e3. Read the comment docs.

@fuxingloh fuxingloh changed the title Updated tailwind and all components to match latest design Updated tailwind and all components to match the latest design Sep 7, 2021
@fuxingloh fuxingloh marked this pull request as ready for review September 7, 2021 17:14
Copy link
Contributor

@siradji siradji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aikchun aikchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fuxingloh fuxingloh merged commit 18555d5 into main Sep 8, 2021
@fuxingloh fuxingloh deleted the fuxingloh/dsm-update-2 branch September 8, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants