Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky random bip32 test #156

Merged
merged 1 commit into from
Apr 23, 2021
Merged

fix flaky random bip32 test #156

merged 1 commit into from
Apr 23, 2021

Conversation

fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

fixed flaky random bip32 test

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.19 KB (0%) 364 ms (0%) 160 ms (+0.23% 🔺) 523 ms

@fuxingloh fuxingloh marked this pull request as ready for review April 23, 2021 03:49
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #156 (c2548a4) into main (5d8e2e4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   95.34%   95.39%   +0.04%     
==========================================
  Files          50       51       +1     
  Lines        1074     1085      +11     
  Branches      130      131       +1     
==========================================
+ Hits         1024     1035      +11     
  Misses         48       48              
  Partials        2        2              
Impacted Files Coverage Δ
...jellyfish-transaction/src/buffer/buffer_varuint.ts 100.00% <ø> (ø)
...llyfish-transaction/src/buffer/buffer_bignumber.ts 100.00% <100.00%> (ø)
...ellyfish-transaction/src/buffer/buffer_composer.ts 98.57% <100.00%> (-0.06%) ⬇️
packages/jellyfish-transaction/src/tx_signature.ts 95.83% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d15e0a...c2548a4. Read the comment docs.

@fuxingloh fuxingloh merged commit 8450e8f into main Apr 23, 2021
@fuxingloh fuxingloh deleted the fuxingloh/bip32-test branch April 23, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants