-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor module exports for api-core & crypto #168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defichain-bot
added
area/jellyfish-api-jsonrpc
kind/refactor
Non feature refactor change
labels
Apr 28, 2021
Deploy preview for jellyfish-defi ready! Built with commit ca1a732 |
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 95.47% 95.40% -0.07%
==========================================
Files 52 52
Lines 1106 1111 +5
Branches 137 136 -1
==========================================
+ Hits 1056 1060 +4
- Misses 48 49 +1
Partials 2 2
Continue to review full report at Codecov.
|
canonbrother
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind refactor
What this PR does / why we need it:
As the modules and packages grow in size, it is becoming increasingly complex to manage imports and exports. Bundling all exports into one index.js file for small modules make senses but for large more complex modules it is harder to effectively manage conflicts.
Hence for larger modules or modules with generic exports, it is wise to use named modules at
index.js
.jellyfish-crypto
to exportsElliptic
,WIF
&Bech32
instead of functionsjellyfish-api-core
to exports 'modules' with their category as the module nameWhich issue(s) does this PR fixes?:
Fixes #130
Additional comments?