Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whale-api): skip null txid used by evmtx #2148

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

pierregee
Copy link
Contributor

@pierregee pierregee commented Sep 16, 2023

What this PR does / why we need it:

  • If an EVM tx is found (2 exact vin - both null), skip it
  • Check how it will impact data representation in DeFiScan (can be done in another PR), vin will be empty as expected

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

  • Add tests on another PR, test all these change in Changi network concurrently

@netlify
Copy link

netlify bot commented Sep 16, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit b55ca42
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/65081407cdf39700083a4d8b
😎 Deploy Preview https://deploy-preview-2148--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #2148 (b55ca42) into main (2f4da37) will increase coverage by 4.41%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
+ Coverage   88.00%   92.42%   +4.41%     
==========================================
  Files         363      372       +9     
  Lines       11000    11213     +213     
  Branches     1435     1459      +24     
==========================================
+ Hits         9681    10364     +683     
+ Misses       1265      813     -452     
+ Partials       54       36      -18     
Files Changed Coverage Δ
apps/whale-api/src/module.indexer/helper.ts 100.00% <100.00%> (ø)
...le-api/src/module.indexer/model/script.activity.ts 97.77% <100.00%> (+0.15%) ⬆️
...api/src/module.indexer/model/script.aggregation.ts 96.96% <100.00%> (+0.14%) ⬆️
...ale-api/src/module.indexer/model/script.unspent.ts 95.12% <100.00%> (+0.38%) ⬆️
...le-api/src/module.indexer/model/transaction.vin.ts 97.36% <100.00%> (+0.14%) ⬆️
...es/testcontainers/src/containers/DeFiDContainer.ts 91.11% <100.00%> (ø)
...tcontainers/src/containers/NativeChainContainer.ts 85.71% <100.00%> (+7.14%) ⬆️

... and 76 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Sep 16, 2023

Docker build preview for jellyfish/apps is ready!

Built with commit a546c65

  • ghcr.io/birthdayresearch/legacy-api:pr-2148
  • ghcr.io/birthdayresearch/playground-api:pr-2148
  • ghcr.io/birthdayresearch/status-api:pr-2148
  • ghcr.io/birthdayresearch/whale-api:pr-2148

You can also get an immutable image with the commit hash

  • ghcr.io/birthdayresearch/legacy-api:a546c65e2ea4bb424cefa1258b1f79aaa45e5e56
  • ghcr.io/birthdayresearch/playground-api:a546c65e2ea4bb424cefa1258b1f79aaa45e5e56
  • ghcr.io/birthdayresearch/status-api:a546c65e2ea4bb424cefa1258b1f79aaa45e5e56
  • ghcr.io/birthdayresearch/whale-api:a546c65e2ea4bb424cefa1258b1f79aaa45e5e56

@lykalabrada lykalabrada force-pushed the pierregee/fix-stucked-indexer-due-to-evmtx branch from cf7cb88 to 2442c09 Compare September 18, 2023 03:31
lykalabrada
lykalabrada previously approved these changes Sep 18, 2023
@thedoublejay thedoublejay merged commit db38bfa into main Sep 19, 2023
32 checks passed
@thedoublejay thedoublejay deleted the pierregee/fix-stucked-indexer-due-to-evmtx branch September 19, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants