txn-builder: utxos-to-account
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-zynesis
commented
May 18, 2021
packages/jellyfish-transaction-builder/src/txn/txn_builder_account.ts
Outdated
Show resolved
Hide resolved
fuxingloh
suggested changes
May 18, 2021
packages/jellyfish-transaction-builder/src/txn/txn_builder_account.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-transaction-builder/src/txn/txn_builder_account.ts
Outdated
Show resolved
Hide resolved
defichain-bot
added
needs/kind
size-limit report 📦
|
fuxingloh
added
kind/feature
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 96.37% 96.41% +0.03%
==========================================
Files 82 83 +1
Lines 2153 2177 +24
Branches 275 280 +5
==========================================
+ Hits 2075 2099 +24
Misses 78 78
Continue to review full report at Codecov.
|
ivan-zynesis
commented
May 19, 2021
|
Deploy Preview for jellyfish-defi ready! Built with commit 1646ac4 |
9 tasks
fuxingloh
suggested changes
May 19, 2021
packages/jellyfish-transaction-builder/src/txn/txn_builder_account.ts
Outdated
Show resolved
Hide resolved
...ges/jellyfish-transaction-builder/__tests__/txn/txn_builder_account_utxos_to_account.test.ts
Show resolved
Hide resolved
|
Code Climate has analyzed commit f283f89 and detected 0 issues on this pull request. View more on Code Climate. |
ivan-zynesis
commented
May 21, 2021
| @@ -76,6 +76,6 @@ export async function findOut (outs: TxOut[], pair: EllipticPair): Promise<TxOut | |||
| const address = Bech32.fromPubKey(pubKey, 'bcrt') | |||
|
|
|||
| return outs.filter(value => { | |||
| return value.scriptPubKey.addresses.includes(address) | |||
| return value.scriptPubKey.addresses?.includes(address) | |||
There was a problem hiding this comment.
To return only Txout when Vout has non utxos output.
fuxingloh
previously approved these changes
May 21, 2021
fuxingloh
changed the title
txn-builder: utxos-to-account
...ges/jellyfish-transaction-builder/__tests__/txn/txn_builder_account_utxos_to_account.test.ts
Show resolved
Hide resolved
canonbrother
approved these changes
May 21, 2021
fuxingloh
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
FE dev friendly DfTx builder (utxos to account)
Which issue(s) does this PR fixes?:
Fixes part of #244
Additional comments?: