Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vin.txid to be decoded in BE order #250

Merged
merged 3 commits into from
May 19, 2021
Merged

Vin.txid to be decoded in BE order #250

merged 3 commits into from
May 19, 2021

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented May 18, 2021

What kind of PR is this?:

/kind chore

What this PR does / why we need it:

Vin.txid to be decoded in BE order but re-encoded as LE. This is for consistency with defid, see #231

Which issue(s) does this PR fixes?:

Fixes #231

@fuxingloh fuxingloh added this to the Jellyfish Wallet milestone May 18, 2021
@fuxingloh fuxingloh changed the title Fuxingloh/refactor txid Vin.txid to be decoded in BE order May 18, 2021
@fuxingloh fuxingloh added the kind/chore Non feature change label May 18, 2021
@github-actions
Copy link

github-actions bot commented May 19, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.93 KB (0%) 379 ms (0%) 168 ms (-1.19% 🔽) 547 ms

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #250 (73221ff) into main (7894dd2) will decrease coverage by 0.08%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   96.46%   96.37%   -0.09%     
==========================================
  Files          82       82              
  Lines        2148     2151       +3     
  Branches      274      274              
==========================================
+ Hits         2072     2073       +1     
- Misses         76       78       +2     
Impacted Files Coverage Δ
...ckages/jellyfish-transaction/src/script/mapping.ts 95.00% <0.00%> (-3.28%) ⬇️
...ellyfish-transaction/src/buffer/buffer_composer.ts 99.37% <100.00%> (ø)
packages/jellyfish-transaction/src/tx_composer.ts 78.57% <100.00%> (ø)
packages/jellyfish-transaction/src/tx_segwit.ts 100.00% <100.00%> (ø)
packages/jellyfish-transaction/src/tx_signature.ts 97.77% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7894dd2...73221ff. Read the comment docs.

@fuxingloh fuxingloh marked this pull request as ready for review May 19, 2021 05:55
@fuxingloh fuxingloh merged commit cfbed46 into main May 19, 2021
@fuxingloh fuxingloh deleted the fuxingloh/refactor-txid branch May 19, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

txid in jellyfish is using LE order, we might want to use BE for consistency
2 participants