Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix send tokens to address should generate #255

Merged
merged 2 commits into from
May 19, 2021

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented May 19, 2021

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

Should container.generate(1) after sending tokens as testing module be fully featured. This removes the need to container.generate(1) from setup code..

@fuxingloh fuxingloh added the kind/fix Fix a bug label May 19, 2021
@fuxingloh fuxingloh marked this pull request as ready for review May 19, 2021 07:54
@defichain-bot defichain-bot removed the kind/feature New feature request label May 19, 2021
@fuxingloh fuxingloh enabled auto-merge (squash) May 19, 2021 07:55
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.95 KB (0%) 380 ms (0%) 163 ms (-3.22% 🔽) 542 ms

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #255 (27d7555) into main (cfbed46) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   96.37%   96.38%           
=======================================
  Files          82       82           
  Lines        2153     2155    +2     
  Branches      275      275           
=======================================
+ Hits         2075     2077    +2     
  Misses         78       78           
Impacted Files Coverage Δ
packages/testing/src/account.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbed46...27d7555. Read the comment docs.

@fuxingloh fuxingloh merged commit 54b3e09 into main May 19, 2021
@fuxingloh fuxingloh deleted the fuxingloh/send-tokens-address-should-generate-1 branch May 19, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants