Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add script estimate service fee #21

Merged
merged 6 commits into from
Jul 14, 2023
Merged

add script estimate service fee #21

merged 6 commits into from
Jul 14, 2023

Conversation

bayram98
Copy link
Contributor

This PR is ready to review and merge.

Changes:

  • Add script to get estimated fee for VRF request
  • Update readme, add how to run script
  • Increase default amount of initial funds
  • Feature to get VRF KeyHash according to each chain

@bayram98 bayram98 self-assigned this Jul 13, 2023
martinkersner
martinkersner approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just left couple minor comments.

scripts/get-account.ts Show resolved Hide resolved
scripts/get-estimated-service-fee.ts Outdated Show resolved Hide resolved
scripts/request-vrf-direct.ts Outdated Show resolved Hide resolved
martinkersner
martinkersner approved these changes Jul 13, 2023
View reviewed changes
scripts/get-estimated-service-fee.ts Outdated Show resolved Hide resolved
@bayram98 bayram98 merged commit b4af1a7 into master Jul 14, 2023
@bayram98 bayram98 deleted the feat/add-script-estimate-service-fee branch July 14, 2023 05:35
@bayram98 bayram98 mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkersner martinkersner martinkersner approved these changes

Assignees

@bayram98 bayram98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bayram98 @martinkersner