Build server address string as of AOS-248 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erly: - add http[s]:// prefix - add port In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
…S-248 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
|
Could you maybe add instructions and screenshots to https://github.com/Bit-Quill/opensearch-project-sql/blob/main/sql-odbc/docs/user/power_bi_support.md? |
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
ghost
approved these changes
Dec 17, 2021
kylepbit
reviewed
Dec 17, 2021
kylepbit
reviewed
Dec 17, 2021
kylepbit
reviewed
Dec 17, 2021
| @@ -186,10 +218,10 @@ SqlOdbcPBIConnector = [ | |||
| // PBIDS Handler | |||
| DSRHandlers = [ | |||
| #"sqlodbc" = [ | |||
| GetDSR = (server, schema, object, optional options) => [ protocol = "sqlodbc", address = [ server = server ] ], | |||
| GetFormula = (dsr, optional options) => () => | |||
| GetDSR = (server, schema, object, optional options) => [ protocol = "sqlodbc", address = [ server = server, port = schema, useSSL = object ] ], | |||
There was a problem hiding this comment.
I discovered that port and useSSL are passed as the second and third arguments.
I'm not sure whether we can rename function arguments, so I kept it as is. I agree it is weird.
There was a problem hiding this comment.
I think you can, have you tried to see if it still works?
kylepbit
reviewed
Dec 17, 2021
Co-authored-by: Kyle Porter <kylep@bitquilltech.com>
Co-authored-by: Kyle Porter <kylep@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
…m:Bit-Quill/opensearch-project-sql into pbi-connector-build-server-string-AOS-248 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
…S-248 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
kylepbit
approved these changes
Dec 20, 2021
…S-248 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
ghost
pushed a commit
that referenced
this pull request
Jan 10, 2022
* Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Typo fix Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fix requested by PR review Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed connector changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Change values to bitmasks Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Reverted some previous changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed generated test output file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed SqlOdbcPBIConnector to OpenSearch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * According to AOS-248, we have to build the server address string properly: - add http[s]:// prefix - add port In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added version and disable trace output as per Microsoft's feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added documentation for the OpenSearch connector Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed connector markdown file to follow naming conventions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed image file extention as it was not being detected by GitHub Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updating docs according to PR #16 comments. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A typo fix in yml Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A dummy commit to make GitHub Actions start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Workflow fix - pack Tableau ODBC connector instead of JDBC one Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix line endings in the workflow file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Another dummy commit to start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix paths in the GitHub workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified workflow to trigger on changes of itself Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Path fix for preparation step Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed PBI connector files Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Moved Tableau JDBC connector to bi-connectors Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added packing Tableau JDBC connector For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed Power BI connector as "OpenSearch Project" Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed output artifact Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Modified code that builds the server string Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed grammatical errors, added a docs directory, and updated the connection string options image Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed md file as it was moved to the docs directory Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed grammatical errors and updated the old power bi support document Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed extra line Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Disabled building Tableau ODBC connector, because it is not ready for shipping Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow step description Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Removed packing ODBC driver for Tableau (re: 4cadfd1). Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow, because connector source files were renamed after merge Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Revert "Add GitHub workflow to pack BI connectors" * Changed string replacement in the main connector file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Script was modified according to PR comments Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Removed Tableau ODBC connector Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Merged OpenSearch-sql main to this branch and updated links as per the PR comment Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> Co-authored-by: Kyle Porter <kylep@bitquilltech.com>
ghost
pushed a commit
that referenced
this pull request
Jan 14, 2022
* Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Typo fix Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fix requested by PR review Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed connector changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Change values to bitmasks Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Reverted some previous changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed generated test output file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed SqlOdbcPBIConnector to OpenSearch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * According to AOS-248, we have to build the server address string properly: - add http[s]:// prefix - add port In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added version and disable trace output as per Microsoft's feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added documentation for the OpenSearch connector Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed connector markdown file to follow naming conventions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed image file extention as it was not being detected by GitHub Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updating docs according to PR #16 comments. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A typo fix in yml Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A dummy commit to make GitHub Actions start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Workflow fix - pack Tableau ODBC connector instead of JDBC one Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix line endings in the workflow file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Another dummy commit to start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix paths in the GitHub workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified workflow to trigger on changes of itself Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Path fix for preparation step Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed PBI connector files Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Moved Tableau JDBC connector to bi-connectors Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added packing Tableau JDBC connector For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed Power BI connector as "OpenSearch Project" Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed output artifact Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Modified code that builds the server string Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed grammatical errors, added a docs directory, and updated the connection string options image Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed md file as it was moved to the docs directory Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed grammatical errors and updated the old power bi support document Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed extra line Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Disabled building Tableau ODBC connector, because it is not ready for shipping Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow step description Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Removed packing ODBC driver for Tableau (re: 4cadfd1). Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow, because connector source files were renamed after merge Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Revert "Add GitHub workflow to pack BI connectors" * Changed string replacement in the main connector file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Script was modified according to PR comments Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added limitations and issues table to connector markdown file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed Tableau ODBC connector Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Merged OpenSearch-sql main to this branch and updated links as per the PR comment Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added link to bug Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made changes as per requested in the PR comments. Linked github issues to issues listed Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added changes to the OpenSearch md file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed unused images Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> Co-authored-by: Kyle Porter <kylep@bitquilltech.com>
Yury-Fridlyand
added a commit
that referenced
this pull request
Feb 23, 2022
* Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Typo fix Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fix requested by PR review Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed connector changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Change values to bitmasks Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Reverted some previous changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed generated test output file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed SqlOdbcPBIConnector to OpenSearch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * According to AOS-248, we have to build the server address string properly: - add http[s]:// prefix - add port In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added version and disable trace output as per Microsoft's feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added documentation for the OpenSearch connector Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed connector markdown file to follow naming conventions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed image file extention as it was not being detected by GitHub Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updating docs according to PR #16 comments. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A typo fix in yml Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A dummy commit to make GitHub Actions start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Workflow fix - pack Tableau ODBC connector instead of JDBC one Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix line endings in the workflow file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Another dummy commit to start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix paths in the GitHub workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified workflow to trigger on changes of itself Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Path fix for preparation step Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed PBI connector files Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Moved Tableau JDBC connector to bi-connectors Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added packing Tableau JDBC connector For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed Power BI connector as "OpenSearch Project" Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed output artifact Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Modified code that builds the server string Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed grammatical errors, added a docs directory, and updated the connection string options image Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed md file as it was moved to the docs directory Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed grammatical errors and updated the old power bi support document Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed extra line Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Disabled building Tableau ODBC connector, because it is not ready for shipping Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow step description Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Removed packing ODBC driver for Tableau (re: 4cadfd1). Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow, because connector source files were renamed after merge Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Revert "Add GitHub workflow to pack BI connectors" * Changed string replacement in the main connector file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Script was modified according to PR comments Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added limitations and issues table to connector markdown file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed Tableau ODBC connector Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Merged OpenSearch-sql main to this branch and updated links as per the PR comment Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added link to bug Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made changes as per requested in the PR comments. Linked github issues to issues listed Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added changes to the OpenSearch md file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Modified the connector and workflows to address Power BI certification feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed m filename to AmazonOpenSearchService-ODBC Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made further changes to address PBI feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed github workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified output filenames of connector workflow Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fix workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Typo fix in the fix Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Changed function prefixes to match connector name Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed DSR Handler Friendly name for Amazon OpenSearch Service connector as requested by the PBI feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed -ODBC suffix as per code review comments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made workflow more concise and changed a variable name Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed irrelevant images Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> Co-authored-by: Kyle Porter <kylep@bitquilltech.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 18, 2023
…pensearch-project#1977) * spotless apply for OpenSearch P1. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Manual spotless changes Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * ignore failures for checkstyles. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Apply suggestions from code review Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Apply suggestions from code review Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Apply suggestions from code review Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Address PR comment Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add order list in Content.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update opensearch/src/main/java/org/opensearch/sql/opensearch/request/system/OpenSearchDescribeIndexRequest.java Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Update opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/MetricParserHelper.java Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Fixing compilation error Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 22, 2023
…pensearch-project#1977) * spotless apply for OpenSearch P1. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Manual spotless changes Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * ignore failures for checkstyles. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Apply suggestions from code review Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Apply suggestions from code review Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Apply suggestions from code review Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Address PR comment Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add order list in Content.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update opensearch/src/main/java/org/opensearch/sql/opensearch/request/system/OpenSearchDescribeIndexRequest.java Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Update opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/MetricParserHelper.java Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Fixing compilation error Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoid bug opensearch-project/sql-odbc#22, we need to build server address string by adding to it
http[s]://prefix.In scope of this task I updated the connection dialog to support 2 new fields:
The resulting address string is built according to the user input.
The code has some protection against incorrect input, for example, it can proceed properly if user already added prefix and/or port.
New connection dialog pic:
Issues Resolved
AOS-248, AOS-239
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.