Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4.44.1 to 4.45 #2948

Merged
merged 3 commits into from
Oct 3, 2024
Merged

V4.44.1 to 4.45 #2948

merged 3 commits into from
Oct 3, 2024

Conversation

benma
Copy link
Contributor

@benma benma commented Oct 1, 2024

No description provided.

@Beerosagos
Copy link
Collaborator

The commit to fix the buy/sell labels can be skipped, I think. It's already in the branch a727fdd

With different translations the action buttons (send, receive, buy
& sell and WC) did not break nicely on small screen.

Due to limited button height the text could be outside of the button
and only visible in darkmode but not in normal mode (white on gray).

Changed to let the buttons break onto 2 lines of text if there is
not enough horozontal space.
@benma
Copy link
Contributor Author

benma commented Oct 1, 2024

The commit to fix the buy/sell labels can be skipped, I think. It's already in the branch a727fdd

Right, I rebased and now the commit is gone from this PR 👍

Copy link
Collaborator

@Beerosagos Beerosagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@benma benma merged commit e43e676 into BitBoxSwiss:release-v4.45.0 Oct 3, 2024
6 checks passed
@benma benma deleted the v4.44.1-to-4.45 branch October 3, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants