feat(abstract-utxo): support trustless change outputs from explaintx #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saravanan7mani
force-pushed
the
BTC-1112-change-outputs
branch
from
9805e6f
to
556dcd5
Compare
saravanan7mani
changed the title
saravanan7mani
force-pushed
the
BTC-1112-change-outputs
branch
5 times, most recently
from
c04c726
to
da11751
Compare
OttoAllmendinger
requested changes
Apr 19, 2024
| .findInternalOutputIndices(psbt) | ||
| .map((i) => utxolib.address.fromOutputScript(txOutputs[i].script, network)); | ||
| } catch (e) { | ||
| if (e instanceof Error && e.message === 'No multi sig input found') { |
There was a problem hiding this comment.
instead of relying on error message we should have a dedicated error class
class ErrorNoMultiSigInputFound extends Error { ... }
...
if (e instanceof ErrorNoMultiSigInputFound) { ... }
but why not propagate the error instead?
There was a problem hiding this comment.
why not propagate the error instead?
As per existing test cases, explainTransaction should return empty change outputs for a PSBT with no multi-sig inputs (ex: PSBT only with p2shP2pk). It makes sense because it's not in explainTransaction's scope to assert for presence of mult-sig inputs in PSBTs.
explainTransaction uses change addresses from platform for its change outputs Now, they are trustlessly deduced from PSBT Ticket: BTC-1112
saravanan7mani
force-pushed
the
BTC-1112-change-outputs
branch
from
da11751
to
445ed53
Compare
OttoAllmendinger
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explainTransaction uses change addresses from platform for its change outputs
Now, they are trustlessly deduced from PSBT
TICKET: BTC-1112