Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add wallet type check for sign transaction #4907

Merged

Conversation

margueriteblair
Copy link
Contributor

Ticket: WP-2664

TICKET: WP-2664

@margueriteblair margueriteblair marked this pull request as ready for review September 16, 2024 14:52
@margueriteblair margueriteblair force-pushed the WP-2664-e-toro-issue-with-the-new-bitgo-express branch from 1a83f84 to ddc04f5 Compare September 16, 2024 15:47
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; but please add a test as a follow up

@margueriteblair margueriteblair merged commit 65b0db0 into master Sep 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants