Drop support for BCH CashAddr #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only remaining place to be updated after this is the README file in the ledger plugin. The other remaining mentions of Bitcoin Cash are legit (references to the BCH fork in 2017, BCH derivation path...) Test plan: Check that it now says "eCash address" in the output of `./electrum-abc rmrequest -h`
This means users can no longer display addresses in the "bitcoincash:..." format, and we no longer open "bitcoincash:" URIs. Users can still paste BCH addresses in the address converter, or convert eCash & legacy addresses to BCH addresses. Test plan: Modify config file to `"address_format": "CashAddr BCH"` and bump version in version.py. Check that the program starts successfully with ecash: addresses in the GUI and updates the config file to `"address_format": "CashAddr"`.
PiRK
force-pushed
the
drop_bitcoincash
branch
from
a94ebec
to
9880275
Compare
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 23, 2024
Summary:
After this diff, bch cash addresses are no longer supported in the "Pay to" field, in BIP21 URIs or any method of entering an address that uses `Address.from_string` without setting `support_arbitrary_prefix=True`.
The address converter in the GUI still support any prefix. This diff also makes the command line / RPC `addressconvert` command support arbitrary prefixes.
But now we no longer support bch addresses without an explicit prefix.
This diff also incidentally fixes support for "ectest:..." URIs when running in testnet mode. Previously `web.parseable_schemes` did not correctly account for the net parameter, and always returned `("ecash", "bitcoincash")`
This is a follow-up to Bitcoin-ABC/ElectrumABC#250 (dropping of display of BCH addresses in the UI).
Test Plan:
```
python test_runner.py
pytest electrumabc.tests.regtest
```
Try the address converter tool in the prefix with various address formats. It should still support everything it did before, except for prefixless "bitcoincash:..." cash addresses.
Reviewers: #bitcoin_abc, Fabien
Reviewed By: #bitcoin_abc, Fabien
Differential Revision: https://reviews.bitcoinabc.org/D15245
Fabcien
pushed a commit
that referenced
this pull request
Jan 24, 2024
Summary:
After this diff, bch cash addresses are no longer supported in the "Pay to" field, in BIP21 URIs or any method of entering an address that uses `Address.from_string` without setting `support_arbitrary_prefix=True`.
The address converter in the GUI still support any prefix. This diff also makes the command line / RPC `addressconvert` command support arbitrary prefixes.
But now we no longer support bch addresses without an explicit prefix.
This diff also incidentally fixes support for "ectest:..." URIs when running in testnet mode. Previously `web.parseable_schemes` did not correctly account for the net parameter, and always returned `("ecash", "bitcoincash")`
This is a follow-up to #250 (dropping of display of BCH addresses in the UI).
Test Plan:
```
python test_runner.py
pytest electrumabc.tests.regtest
```
Try the address converter tool in the prefix with various address formats. It should still support everything it did before, except for prefixless "bitcoincash:..." cash addresses.
Reviewers: #bitcoin_abc, Fabien
Reviewed By: #bitcoin_abc, Fabien
Differential Revision: https://reviews.bitcoinabc.org/D15245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the support for the BCH CashAddr format in the UI.
We just keep the ability to convert adresses to/from this format for the sake of the address conversion tool.
Drop support for "bitcoincash:" URIs.
Also remove a few remaining mentions of Electron Cash and Bitcoin Cash in doc, strings and comments.