Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to throw errors, not return them #27

Closed
christroutner opened this issue Mar 8, 2019 · 1 comment · Fixed by #48
Closed

Need to throw errors, not return them #27

christroutner opened this issue Mar 8, 2019 · 1 comment · Fixed by #48
Labels
bug Something isn't working

Comments

@christroutner
Copy link
Contributor

christroutner commented Mar 8, 2019 •
edited
Loading

The libraries in SLP SDK are riddled with the pattern of return error instead of throw error. Returning an error will not trigger an error handler. Here is an example

The scope of this Issue is to refactor all the libraries in SLP SDK and replace instances of return error with throw error.
@christroutner christroutner added the bug Something isn't working label Mar 8, 2019
@blockparty-sh blockparty-sh mentioned this issue Jun 10, 2019
Open
blockparty-sh added a commit to blockparty-sh/slp-sdk that referenced this issue Jun 11, 2019
@blockparty-sh
throw errors instead of returning them, this fixes Bitcoin-com#27
e5e62f6
@blockparty-sh blockparty-sh mentioned this issue Jun 11, 2019
Closed
@cgcardona cgcardona mentioned this issue Jun 21, 2019
Merged
@cgcardona
Copy link
Contributor

This is resolved in SLP SDK v4.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v4.4.1 Bitcoin-com/slp-sdk
2 participants
@cgcardona @christroutner