Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace regular space with thin space in thousands separators in units & symbols page #1086

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

GBKS
Copy link
Contributor

@GBKS GBKS commented May 2, 2024

As is the standard in the International System of Units, and also looks better. More info on the thin space here.

Goal is to have a slight separation of numbers, but not a big gap. The thin space is (naturally) less wide than a regular space (which is often used), achieving that effect.

Side-by-side, the images updates in this PR will be difficult to compare. You really need to overlay them on top of each other (top one with transparency), to see the difference.

As is the standard in the International System of Units, and also looks better. More info on the thin space here: https://en.wikipedia.org/wiki/Thin_space
@GBKS GBKS added Design Task is about designing something. Design bitcoin products Referring to the Design BTC product section. labels May 2, 2024
@GBKS GBKS self-assigned this May 2, 2024
Copy link

netlify bot commented May 2, 2024

Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit 77de6e6
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/663393c0c8a56b000827d439
😎 Deploy Preview https://deploy-preview-1086--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Old one was outdated, since the illustrations were moved out of the main UI Kit file.
Copy link
Collaborator

@rabbitholiness rabbitholiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mouxdesign
Copy link
Collaborator

Extracted the images and overlayed them.

It feels as if the spacing has been reduced with the second half of the numbers and less with the first half. This could also be due to how they were overlayed. Top image is the updated version at 60% opacity. Bottom is the original one.
Group 2 (14)

@GBKS
Copy link
Contributor Author

GBKS commented May 22, 2024

It feels as if the spacing has been reduced with the second half of the numbers and less with the first half. This could also be due to how they were overlayed. Top image is the updated version at 60% opacity. Bottom is the original one.

Correct. The spaces are more narrow.

@GBKS GBKS requested a review from mouxdesign May 22, 2024 12:34
@GBKS
Copy link
Contributor Author

GBKS commented May 22, 2024

@rabbitholiness I saw you left a review, could please also accept the changes in your review so I can go ahead and merge?

@GBKS GBKS merged commit b482244 into master Jun 20, 2024
4 checks passed
@GBKS GBKS deleted the feature/units-and-symbols-thin-space branch June 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design bitcoin products Referring to the Design BTC product section. Design Task is about designing something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants