-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace regular space with thin space in thousands separators in units & symbols page #1086
Conversation
As is the standard in the International System of Units, and also looks better. More info on the thin space here: https://en.wikipedia.org/wiki/Thin_space
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Old one was outdated, since the illustrations were moved out of the main UI Kit file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Correct. The spaces are more narrow. |
@rabbitholiness I saw you left a review, could please also accept the changes in your review so I can go ahead and merge? |
As is the standard in the International System of Units, and also looks better. More info on the thin space here.
Goal is to have a slight separation of numbers, but not a big gap. The thin space is (naturally) less wide than a regular space (which is often used), achieving that effect.
Side-by-side, the images updates in this PR will be difficult to compare. You really need to overlay them on top of each other (top one with transparency), to see the difference.