Porting bitmessageqt to Qt5 #1389
Conversation
|
Can we have some sort of fallback qtpy bundled? |
|
The source doesn't look big, most of it are tests. And it's under MIT license. |
|
Probably yes. I thought of it, just forgot. I think it should be slim compatibility layer which just imports PyQt5. BTW, I decided to finish UI refactoring in separate branch. |
src/depends.py
Outdated
| passed = True | ||
| if QtCore.PYQT_VERSION < 0x40800: | ||
| if qtpy.PYQT_VERSION < '4.8': |
There was a problem hiding this comment.
These tests are wrong as they compare strings and it thinks '4.11.4' < '4.8'. You need to use
from distiutils.version import LooseVersion
and then wrap these comparisons in LooseVersion like qtpy does it.
src/depends.py
Outdated
| logger.error( | ||
| 'This version of PyQt is too old. PyBitmessage requries' | ||
| ' PyQt 4.8 or later.') | ||
| passed = False | ||
| if QtCore.QT_VERSION < 0x40700: | ||
| if qtpy.QT_VERSION < '4.7': |
There was a problem hiding this comment.
same problem here, should use LooseVersion
|
I tried it, and it runs both with pyqt4 and pyqt5 and you can use the environment variable |
|
qt4 is being less and less supported by the main distros |
g1itch
force-pushed
the
qt5-wip
branch
7 times, most recently
from
16ef2e7
to
8bb7679
Compare
g1itch
force-pushed
the
qt5-wip
branch
7 times, most recently
from
3475e20
to
8a8b81c
Compare
|
Perhaps now you can do a review. |
g1itch
force-pushed
the
qt5-wip
branch
2 times, most recently
from
3c9c400
to
83b8b10
Compare
g1itch
force-pushed
the
qt5-wip
branch
2 times, most recently
from
259b78e
to
f3c4129
Compare
(closes Bitmessage#897, closes Bitmessage#1418)
resolved pylint redefined-variable-type warnings, marked autogenerated modules for skipping by pylint and flake8
on tabs "Send", "Blacklist" and "Network Status": in qt5 it's probably true by default.
Hello!
I realized that column width problem in
QTableWidgetwas actually the Qt bug.I mostly finished work in this branch though it still needs some testing.