Changes based on style and lint checks. (final_code_quality_19) #1401

coffeedogs · 2018-11-26T15:54:00Z

Changes based on style and lint checks. (final_code_quality_19)

PeterSurda · 2018-12-04T11:52:54Z

src/network/dandelion.py

 @Singleton
-class Dandelion():
+class Dandelion:
+    """"""


Suggested change

""""""

"""Dandelion class for tracking stem/fluff stages."""

PeterSurda · 2018-12-04T11:54:15Z

src/network/dandelion.py

@@ -35,44 +44,52 @@ def __init__(self):
        self.lock = RLock()

    def poissonTimeout(self, start=None, average=0):
+        """"""


Suggested change

""""""

"""Generate deadline using Poisson distribution"""

PeterSurda · 2018-12-04T11:56:00Z

src/network/dandelion.py


    def addHash(self, hashId, source=None, stream=1):
+        """"""


Suggested change

""""""

"""Add inventory vector to dandelion stem"""

PeterSurda · 2018-12-04T11:57:10Z

src/network/dandelion.py


    def setHashStream(self, hashId, stream=1):
+        """"""


Suggested change

""""""

"""Update stream for inventory vector (as inv/dinv commands don't include streams, we only learn this after receiving the object)"""

PeterSurda · 2018-12-04T11:58:10Z

src/network/dandelion.py


    def removeHash(self, hashId, reason="no reason specified"):
-        logging.debug("%s entering fluff mode due to %s.", ''.join('%02x'%ord(i) for i in hashId), reason)
+        """"""


Suggested change

""""""

"""Switch inventory vector from stem to fluff mode"""

PeterSurda · 2018-12-04T11:58:54Z

src/network/dandelion.py

        with self.lock:
            try:
                del self.hashMap[hashId]
            except KeyError:
                pass

    def hasHash(self, hashId):
+        """"""


Suggested change

""""""

"""Is inventory vector in stem mode?"""

PeterSurda · 2018-12-04T11:59:54Z

src/network/dandelion.py

        return hashId in self.hashMap

    def objectChildStem(self, hashId):
+        """"""


Suggested change

""""""

"""Child (i.e. next) node for an inventory vector during stem mode"""

PeterSurda · 2018-12-04T12:02:05Z

src/network/dandelion.py

        return self.hashMap[hashId].child

    def maybeAddStem(self, connection):
+        """"""


Suggested change

""""""

"""If we had too few outbound connections, add the current one to the current stem list. Dandelion as designed by the authors should always have two active stem child connections."""

PeterSurda · 2018-12-04T12:02:46Z

src/network/dandelion.py

    def maybeRemoveStem(self, connection):
+        """"""


Suggested change

""""""

"""Remove current connection from the stem list (called e.g. when a connection is closed)."""

PeterSurda · 2018-12-04T12:04:06Z

src/network/dandelion.py

@@ -96,6 +113,7 @@ def maybeRemoveStem(self, connection):
                    self.hashMap[k] = Stem(None, v.stream, self.poissonTimeout())

    def pickStem(self, parent=None):
+        """"""


Suggested change

""""""

"""Pick a random active stem, but not the parent one (the one where an object came from)"""

PeterSurda · 2018-12-04T12:05:42Z

src/network/dandelion.py

@@ -112,6 +130,7 @@ def pickStem(self, parent=None):
            return None

    def getNodeStem(self, node=None):
+        """"""


Suggested change

""""""

"""Return child stem node for a given parent stem node (the mapping is static for about 10 minutes, then it reshuffles)"""

PeterSurda · 2018-12-04T12:07:04Z

src/network/dandelion.py

@@ -120,15 +139,18 @@ def getNodeStem(self, node=None):
                return self.nodeMap[node]

    def expire(self):
+        """"""


Suggested change

""""""

"""Switch expired objects from stem to fluff mode"""

PeterSurda · 2018-12-04T12:07:42Z

src/network/dandelion.py

            for row in toDelete:
                self.removeHash(row[1], 'expiration')
                invQueue.put((row[0], row[1], row[2]))

    def reRandomiseStems(self):
+        """"""


Suggested change

""""""

"""Re-shuffle stem mapping (parent <-> child pairs)"""

PeterSurda · 2018-12-04T12:08:28Z

src/network/socks4a.py


 class Socks4aError(ProxyError):
+    """"""


Suggested change

""""""

"""SOCKS4a error base class"""

PeterSurda · 2018-12-04T12:08:41Z

src/network/socks4a.py



 class Socks4a(Proxy):
+    """"""


Suggested change

""""""

"""SOCKS4a proxy class"""

PeterSurda · 2018-12-04T12:09:00Z

src/network/socks4a.py

    def __init__(self, address=None):
        Proxy.__init__(self, address)
        self.ipaddr = None
        self.destport = address[1]

    def state_init(self):
+        """"""


Suggested change

""""""

"""Protocol initialisation (before connection is established)"""

PeterSurda · 2018-12-04T12:09:45Z

src/network/socks4a.py

        self.set_state("auth_done", 0)
        return True

    def state_pre_connect(self):
+        """"""


Suggested change

""""""

"""Handle feedback from SOCKS4a while it is connecting on our behalf."""

PeterSurda · 2018-12-04T12:10:54Z

src/network/socks4a.py

@@ -47,14 +58,17 @@ def state_pre_connect(self):
        return True

    def proxy_sock_name(self):
-       return socket.inet_ntoa(self.__proxysockname[0])
+        """"""


Suggested change

""""""

"""Handle return value when using SOCKS4a for DNS resolving instead of connecting."""

PeterSurda · 2018-12-04T12:12:32Z

src/network/socks4a.py



 class Socks4aConnection(Socks4a):
+    """"""


Suggested change

""""""

"""Child SOCKS4a class used for making outbound connections."""

PeterSurda · 2018-12-04T12:12:50Z

src/network/socks4a.py

    def __init__(self, address):
        Socks4a.__init__(self, address=address)

    def state_auth_done(self):
+        """"""


Suggested change

""""""

"""Request connection to be made"""

PeterSurda · 2018-12-04T12:13:24Z

src/network/socks4a.py

@@ -83,6 +97,7 @@ def state_auth_done(self):
        return True

    def state_pre_connect(self):
+        """"""


Suggested change

""""""

"""Tell SOCKS4a to initiate a connection"""

PeterSurda · 2018-12-04T12:13:49Z

src/network/socks4a.py

    def __init__(self, host):
        self.host = host
        self.port = 8444
        Socks4a.__init__(self, address=(self.host, self.port))

    def state_auth_done(self):
+        """"""


Suggested change

""""""

"""DNS resolver class using SOCKS4a"""

PeterSurda · 2018-12-04T12:14:15Z

src/network/socks4a.py

@@ -108,4 +125,5 @@ def state_auth_done(self):
        return True

    def resolved(self):
+        """"""


Suggested change

""""""

"""Resolving is done, process the return value. To use this within PyBitmessage, a callback needs to be

implemented which hasn't been done yet."""

PeterSurda

Update docstrings, otherwise ok.

Changes based on style and lint checks. (final_code_quality_19)

85f743d

PeterSurda reviewed Dec 4, 2018

View reviewed changes

src/network/socks4a.py

class Socks4aError(ProxyError):

""""""

Copy link

Member

PeterSurda Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

""""""

"""SOCKS4a error base class"""

PeterSurda reviewed Dec 4, 2018

View reviewed changes

src/network/socks4a.py

class Socks4a(Proxy):

""""""

Copy link

Member

PeterSurda Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

""""""

"""SOCKS4a proxy class"""

PeterSurda reviewed Dec 4, 2018

View reviewed changes

PeterSurda requested changes Dec 4, 2018

View reviewed changes

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 8, 2019

Docstrings in network.dandelion from Bitmessage#1401

91dfd4b

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 8, 2019

Docstrings in network.socks4a from Bitmessage#1401

340dcb7

g1itch closed this Jul 8, 2019

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 8, 2019

Docstrings in network.dandelion from Bitmessage#1401

87cc381

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 8, 2019

Docstrings in network.socks4a from Bitmessage#1401

d2ba531

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 10, 2019

Docstrings in network.dandelion from Bitmessage#1401

9791b58

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 10, 2019

Docstrings in network.socks4a from Bitmessage#1401

9f4d288

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 11, 2019

Docstrings in network.dandelion from Bitmessage#1401

a0a7f34

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 11, 2019

Docstrings in network.socks4a from Bitmessage#1401

421fa16

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 25, 2019

Docstrings in network.dandelion from Bitmessage#1401

0c6232e

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 25, 2019

Docstrings in network.socks4a from Bitmessage#1401

2694ab1

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Jul 26, 2019

Docstrings in network from Bitmessage#1401

2998599

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Aug 17, 2021

Docstrings in network.dandelion from Bitmessage#1401

c098712

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes based on style and lint checks. (final_code_quality_19) #1401

Changes based on style and lint checks. (final_code_quality_19) #1401

coffeedogs commented Nov 26, 2018

PeterSurda Dec 4, 2018 •

edited

Loading

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018 •

edited

Loading

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018 •

edited

Loading

PeterSurda Dec 4, 2018 •

edited

Loading

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda Dec 4, 2018

PeterSurda left a comment

	""""""
	"""Update stream for inventory vector (as inv/dinv commands don't include streams, we only learn this after receiving the object)"""

	""""""
	"""Child (i.e. next) node for an inventory vector during stem mode"""

	""""""
	"""If we had too few outbound connections, add the current one to the current stem list. Dandelion as designed by the authors should always have two active stem child connections."""

	""""""
	"""Remove current connection from the stem list (called e.g. when a connection is closed)."""

	""""""
	"""Pick a random active stem, but not the parent one (the one where an object came from)"""

	""""""
	"""Return child stem node for a given parent stem node (the mapping is static for about 10 minutes, then it reshuffles)"""

	""""""
	"""Re-shuffle stem mapping (parent <-> child pairs)"""

	""""""
	"""Protocol initialisation (before connection is established)"""

	""""""
	"""Handle feedback from SOCKS4a while it is connecting on our behalf."""

	""""""
	"""Handle return value when using SOCKS4a for DNS resolving instead of connecting."""

	""""""
	"""Child SOCKS4a class used for making outbound connections."""

	""""""
	"""Resolving is done, process the return value. To use this within PyBitmessage, a callback needs to be
	implemented which hasn't been done yet."""

Changes based on style and lint checks. (final_code_quality_19) #1401

Changes based on style and lint checks. (final_code_quality_19) #1401

Conversation

coffeedogs commented Nov 26, 2018

PeterSurda Dec 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PeterSurda Dec 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PeterSurda Dec 4, 2018 • edited Loading

Choose a reason for hiding this comment

PeterSurda Dec 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PeterSurda left a comment

Choose a reason for hiding this comment

PeterSurda Dec 4, 2018 •

edited

Loading

PeterSurda Dec 4, 2018 •

edited

Loading

PeterSurda Dec 4, 2018 •

edited

Loading

PeterSurda Dec 4, 2018 •

edited

Loading