Use region code instead Locale in defaultCountry #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locale was kind of overkill as we only need the isoRegionCode to determine the default country. It also enables persisting this code for apps that e.g. use the country picker at login time. The persisted code can then be used to re-initialize a phone number view controller with an existing number when the user wants to edit it. Apart from this i streamlined the wording to `isoCountryCode` when referring to the two-letter [ISO 3166](https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes) code of a country.
Blackjacx
force-pushed
the
refactor-default-country
branch
from
d69ab48
to
a11da3c
Compare
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use region code instead Locale in defaultCountry
Locale was kind of overkill as we only need the isoRegionCode to
determine the default country. It also enables persisting this code for
apps that e.g. use the country picker at login time. The persisted
code can then be used to re-initialize a phone number view controller
with an existing number when the user wants to edit it.
Apart from this i streamlined the wording to
isoCountryCodewhenreferring to the two-letter ISO 3166
code of a country.