Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crossbeam_utils instead crossbeam #7

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

l4l
Copy link
Contributor

@l4l l4l commented Dec 3, 2020

It seems that crossbeam only used for threading, so no need to depending on the whole framework, but only utils part.

Before:

fuse-rust v0.1.3
└── crossbeam v0.7.3
    ├── cfg-if v0.1.10
    ├── crossbeam-channel v0.4.4
    │   ├── crossbeam-utils v0.7.2
    │   │   ├── cfg-if v0.1.10
    │   │   └── lazy_static v1.4.0
    │   │   [build-dependencies]
    │   │   └── autocfg v1.0.1
    │   └── maybe-uninit v2.0.0
    ├── crossbeam-deque v0.7.3
    │   ├── crossbeam-epoch v0.8.2
    │   │   ├── cfg-if v0.1.10
    │   │   ├── crossbeam-utils v0.7.2 (*)
    │   │   ├── lazy_static v1.4.0
    │   │   ├── maybe-uninit v2.0.0
    │   │   ├── memoffset v0.5.6
    │   │   │   [build-dependencies]
    │   │   │   └── autocfg v1.0.1
    │   │   └── scopeguard v1.1.0
    │   │   [build-dependencies]
    │   │   └── autocfg v1.0.1
    │   ├── crossbeam-utils v0.7.2 (*)
    │   └── maybe-uninit v2.0.0
    ├── crossbeam-epoch v0.8.2 (*)
    ├── crossbeam-queue v0.2.3
    │   ├── cfg-if v0.1.10
    │   ├── crossbeam-utils v0.7.2 (*)
    │   └── maybe-uninit v2.0.0
    └── crossbeam-utils v0.7.2 (*)

and after:

fuse-rust v0.1.3
└── crossbeam-utils v0.8.1
    ├── cfg-if v1.0.0
    └── lazy_static v1.4.0
    [build-dependencies]
    └── autocfg v1.0.1

@Blakeinstein
Copy link
Owner

Blakeinstein commented Dec 4, 2020

Brilliant!
I was already very skeptical of including a library to have scoped threads... with my goal being a no dependency library. Thanks for this! I will push this to release as well, I guess.

@Blakeinstein Blakeinstein merged commit a40e5a0 into Blakeinstein:master Dec 4, 2020
@Blakeinstein Blakeinstein added the enhancement New feature or request label Dec 4, 2020
@l4l l4l deleted the reduce-deps branch December 4, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants