-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error if "This model's maximum context length is 4097" #10
Comments
I am aware of this error and am planning to add a notification for whenever an error occurs. However, I am not sure if we should handle commit messages for diffs larger than 4097 tokens. We could split the diff into multiple API requests, but commit message wouldn't reflect the whole change then. Any ideas or suggestion how to solve this are welcome. |
@CrazyBoy49z You are absolutely correct. Error notifications have been added in version 0.5.0. |
Maybe there is a need to add a feature to generate a commit message with some optional files. I use it in front-end projects where some html / svg code formatting generates code changes that should not generate a commit message |
Hi @StringKe. The commit message is generated only from the file changes that are selected in the commit dialog. You can also be very specific, and selected only the lines that are important. I do understand your problem though, maybe we could somehow filter out the changes that only contain whitespace changes? |
I think it's important to include some lock file changes in addition to removing spaces, and I don't know if you know about node package management tools like npm yarn pnpm that produce a lock file that is very large and has a lot of changes per change. I would prefer that I choose to use diff of those files to generate the definitions, rather than all the files added to the git add staging. |
Sorry, but I'm not sure I understand correctly. Isn't lock file also in the commit dialog? If it is, you can use it to generate commit message. If the whole lock file is too big, you can mark only specific lines in the commit dialog. The commit message is generated only from the files (or more specifically lines) that are marked for commit in commit dialog. Maybe add an example? |
The files The |
Oh alright. So you would like an exclusion list? So you can make a list of file path globs and if file's path matches that glob, it is never used when generating commit message? I could maybe add this. The current workaround would be to just not select the lock file ( Did I understand correctly? |
Yes, the understanding is correct. of course there is another way of solving it, I guess.
|
That's an interesting solution. The problem I see with it, is that the user won't know exactly what was used for generating commit message. This could be confusing. That is, if you just ignore all other changes once you reached edit: The way it works now, the user can split the changes to multiple smaller commits and has full control what gets used. |
Yes, very true. When the project is large, a commit is meant to implement a certain feature, and splitting is incorrect behavior and does not facilitate project management. |
Hello! |
The text was updated successfully, but these errors were encountered: