Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom toast component, samples, + unit tests #126

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Added custom toast component, samples, + unit tests #126

merged 1 commit into from
Oct 8, 2021

Conversation

OliverBack
Copy link
Collaborator

This PR contains adding the ability to pass a custom component to the show toast service.

  • Added ShowToast overload to accept a custom component, including a combination of toast parameter and toast instance settings.
  • Updated ToastServiceTests for ShowToast component methods
  • Included example bUnit test.
  • Added signing to Toast and ToastExtensions with a strong name including applying InternalsVisibleToAttribute for Toast.TestExtensions
  • Updated Readme examples

anitagov
anitagov approved these changes Sep 24, 2021
View reviewed changes
Copy link

@anitagov anitagov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @OliverBack

@chrissainty chrissainty added the Feature New feature that will be added to the project label Oct 1, 2021
@chrissainty chrissainty merged commit f768e3a into Blazored:main Oct 8, 2021
@OliverBack OliverBack deleted the add-custom-toast-component branch October 8, 2021 12:29
This was referenced Oct 8, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anitagov anitagov anitagov approved these changes

Assignees
No one assigned
Labels
Feature New feature that will be added to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OliverBack @anitagov @chrissainty