Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component & Redux 설계 #12

Closed
8 tasks done
Seogeurim opened this issue Jul 4, 2020 · 4 comments
Closed
8 tasks done

Component & Redux 설계 #12

Seogeurim opened this issue Jul 4, 2020 · 4 comments
Labels
Let's do this! Gotta go...

Comments

@Seogeurim
Copy link
Member

Seogeurim commented Jul 4, 2020 •
edited
Loading

#5 Code Refactoring 이슈에서 남겨두었던 Component & Redux 설계에 대한 이슈입니다.

해야할 것

  • 1. 컴포넌트 나누는 단위 => 원자적으로 쪼개기
  • 2. 리덕스로 관리할 데이터
  • 3. 서버 요청 구조 & 요청 함수 통일
  • 4. SignUp 컴포넌트, 페이지, 리덕스 설계
  • 5. Layout / Common 컴포넌트 설계

공부할 것

  • Redux, Redux ducks 구조, Redux-saga
  • Component based development
  • Login 관련 프로젝트
@Seogeurim Seogeurim added the Let's do this! Gotta go... label Jul 4, 2020
@Seogeurim Seogeurim mentioned this issue Jul 5, 2020
Merged
@KimKwon KimKwon mentioned this issue Jul 5, 2020
Merged
@Seogeurim Seogeurim mentioned this issue Jul 8, 2020
Closed
Seogeurim added a commit that referenced this issue Jul 10, 2020
@Seogeurim
refactor components architecture #12
f7fb9db 
1. remove index.js & index.scss file 
2. rename file names to index
3. move pages related to signup to components
4. add eslintConfig settings : src absolute path
Seogeurim added a commit that referenced this issue Jul 10, 2020
@Seogeurim
create .eslintrc file #12
0dd78f7
Seogeurim added a commit that referenced this issue Jul 10, 2020
@Seogeurim
fix import error #12
daf93f1
@Seogeurim Seogeurim mentioned this issue Jul 10, 2020
Merged
KimKwon added a commit that referenced this issue Jul 10, 2020
@KimKwon
applying ducks pattern to authReducer
00d62df 
#12
KimKwon added a commit that referenced this issue Jul 11, 2020
@KimKwon
remove action-types, dup code and add util dir #12
da585af 
덕스 구조 적용해나가는 중..
@KimKwon
Copy link
Member

KimKwon commented Jul 11, 2020

Redux-saga 대신에 일단 Redux-thunk를 먼저 보고 있어요
저희 코드가 thunk 미들웨어 라이브러리를 쓰고 있어서 일단 코드를 이해하려면 thunk부터 이해하는게 맞는 것 같아서...
일단 완벽히 이해하고 깔끔하게 코드좀 리팩토링하고 우리 프로젝트에 saga가 이점을 가져다 준다면 saga로 전환하려고...생각..중...
끄적...끄적...

@Seogeurim
Copy link
Member Author

  1. 리덕스로 관리할 데이터

서버와 통신하여 주고 받을 데이터를 리덕스에서 관리할 데이터로 설정하기로 하였습니다.

Seogeurim added a commit that referenced this issue Jul 14, 2020
@Seogeurim
modify Prop-Type #12
a8c6b34
@KimKwon
Copy link
Member

KimKwon commented Jul 14, 2020

알겠습니다~~~~~~~~~~!

KimKwon added a commit that referenced this issue Jul 15, 2020
@KimKwon
fix postaction dup code #12
8a90a0f
@Seogeurim
Copy link
Member Author

  1. 서버 요청 구조 & 요청 함수 통일

요청 함수 : fetch로 통일

  1. SignUp 컴포넌트, 페이지, 리덕스 설계

(Page)SignUpPage, (Component)SignUpForm

@Seogeurim Seogeurim mentioned this issue Jul 15, 2020
Merged
@KimKwon KimKwon mentioned this issue Jul 18, 2020
Closed
KimKwon added a commit that referenced this issue Jul 18, 2020
@KimKwon
modify Ducks pattern, add actionCreator func. #12
09299ef
@KimKwon KimKwon mentioned this issue Jul 18, 2020
Merged
KimKwon added a commit that referenced this issue Jul 19, 2020
@KimKwon
apply handleAction and createAction #12
ad8cc17 
using redux-actions
KimKwon added a commit that referenced this issue Jul 21, 2020
@KimKwon
fix lint error and remove Redux/Actions #12
0087b89 
apply suggested change #22
Seogeurim added a commit that referenced this issue Jul 28, 2020
@Seogeurim
modify component structure #12
f28b60c
Seogeurim added a commit that referenced this issue Aug 2, 2020
@Seogeurim
modify component structure #12
31a4be3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Let's do this! Gotta go...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Seogeurim @KimKwon