Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better download handling and fix typo in readme #74

Merged
merged 3 commits into from
Jun 9, 2017

Conversation

stepri
Copy link
Contributor

@stepri stepri commented Jun 8, 2017

No description provided.

@swapsCAPS
Copy link
Contributor

w00t! Does this fix the Buffer toString() error?

@brendannee
Copy link
Member

How common is the "realtime_trip_id" field in trips.txt in GTFS files? Is this something a lot of agencies are likely to have, or is it a one-off thing for a specific agency?

@stepri
Copy link
Contributor Author

stepri commented Jun 9, 2017

@stofstik For me it worked with this improved code. The "the Buffer toString()" occurs when the .zip GTFS file is langer than 256MB. See nodejs/node#3175
@brendannee I'm not really a GTFS expert, but I needed this to be an index for speed improvements.

@brendannee brendannee merged commit 65d6ae9 into BlinkTagInc:master Jun 9, 2017
@brendannee
Copy link
Member

This looks good - I accepted it but then made a few changes to use the "node-fetch" module instead of "request" and to use promises instead.

I also removed the "realtime_trip_id" field from trip.txt since I haven't seen anything about this field being commonly used. @stepri Does the GTFS file you are using contain this field?

Try out the latest code on the "master" branch and let me know if you have any problems and if the "Buffer toString()" issue is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants