Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix effect shader compile error #678

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

kato-megumi
Copy link
Contributor

Fix effect unable to compile when 'Make effect parameters inline' option is enabled.
#676

@Blinue Blinue linked an issue Jul 13, 2023 that may be closed by this pull request
@Blinue
Copy link
Owner

Blinue commented Jul 13, 2023

Thank you! Considering the limitations of macros, I now lean towards implementing inline parameters as static constants.

@Blinue Blinue merged commit 92153c8 into Blinue:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debanding causes Magpie to not scale anymore
2 participants