Add support for python 2 and 3 when installing on Windows #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is already PR #706 that is almost identical to this. |
|
Would it be possible to merge this change? Right now, it's not possible to develop on Windows since Python 2.x is gone. |
|
Thank you @mdowds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing node-rdkafka on Windows, if
pythonon your PATH points to python 3, the installation fails with an error about being unable to import urllib2. This PR changes the installation script so it tries to import the python 3 module first, and fall back on the python 2 module. This will allow installation regardless of the python version you have as your default.