Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cargo Clean #398

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Fix Cargo Clean #398

merged 2 commits into from
Mar 28, 2024

Conversation

ErikDeSmedt
Copy link
Collaborator

@ErikDeSmedt ErikDeSmedt commented Mar 27, 2024

To reproduce the issue do make docker-image, make docker-shell,
cargo clean.

The issue is that you lack the rights to delete tmp/gltesting/target.
The folder was added as a volume and cannot be deleted.

We keep the rust target directory in /tmp/gltesting/target/target
instead so it can be safely deleted.

I'd recommend to run rm -rf /tmp/gltesting on the host-machine after merging this update.

Makefile Outdated Show resolved Hide resolved
@Randy808
Copy link
Collaborator

I was still having some permission issues so I ended up executing a shell in the container as root with:
docker exec -u root -it <container_id> bash

and running:
chown -R <user> /tmp/gltesting

@ErikDeSmedt
Copy link
Collaborator Author

ErikDeSmedt commented Mar 27, 2024 via email

@Randy808
Copy link
Collaborator

It was a one time action

To reproduce the issue do `make docker-image`, `make docker-shell`,
`cargo clean`.

The issue is that you lack the rights to delete `tmp/gltesting/target`.
The folder was added as a volume and cannot be deleted.

We keep the rust target directory in `/tmp/gltesting/target/target`
instead so it can be safely deleted.
@ErikDeSmedt ErikDeSmedt merged commit 5cc51f5 into Blockstream:main Mar 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants