-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/serviceproviders uniquelinks #143
Feature/serviceproviders uniquelinks #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
several lines of commented out code (in line comments). Need to change baseURL.
will do! good catch! |
this PR is going to cause merge conflicts with my PR request |
did you already merge yours to master? we'll need to do that with either this one or the other, depending on which one gets added first. |
mine is waiting to be added I cleaned out a lot of code in the movie card that's why I say its going to cause conflict |
some of the code you deleted i actually uncommented for the 'where to watch' btn, so that might be an issue, but if you merge yours to master, i can bring those changes back and that shouldn't mess with ur edits right? since you just worked on the movie slider for the ratings page? my edits are more geared towards the service providers button/links |
I'm going to merge just to see what it looks like deployed but would love for Mike to do another check to make sure it doesn't have errant code lines. |
Description
Type of change
Change Status
Checklist