Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forking cal #356

Merged
merged 7 commits into from
Feb 1, 2019
Merged

Forking cal #356

merged 7 commits into from
Feb 1, 2019

Conversation

kamry-bowman
Copy link
Contributor

Description

This allows colorization on resize/move events. I had to move us onto a forked version of react-big-calendar called cadence-big-calendar, but ideally the functionality will get PR'd into react-big-calendar from this PR here. Once that gets merged in we can go back to main calendar, but even if we can't I think the functionality is worth it, as it really ties the room together.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Change status

  • Complete, tested, ready to review and merge
  • Complete, but not tested (may need new tests)
  • Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

Tested in dev environment

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code has been reviewed by at least one peer
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

Copy link
Contributor

@axolotl axolotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super impressive. Great work!

@ahmed-belhadj ahmed-belhadj merged commit b5f043a into master Feb 1, 2019
@rd825 rd825 deleted the forking-cal branch February 5, 2019 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants