This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
do not assume that np.array
does the right thing
#218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #217. The fix there only works for transposed arrays, but it still fails to fix errors with, for example, pandas dataframes:
This is the same example we had in #217, run with latest master (e260ca7) installed on latest anaconda. I'm working in a fix for this that will do the right thing (the first commit here is a step, but breaks other conversions).