Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #64

Merged
merged 2 commits into from
Jun 23, 2017
Merged

Tests #64

merged 2 commits into from
Jun 23, 2017

Conversation

FrancescElies
Copy link
Member

@FrancescElies FrancescElies commented Jun 20, 2017

#63 followup

  • Adds a test
  • Modifies the array size of the previous test

If I understand correctly 256 items (float32) array is still uncompressible, right?
Which is the minimum length at which it starts to be compressed?

Best

@FrancescElies
Copy link
Member Author

It seems I made a mistake somewhere, I'll have a look later today or tomorrow

Creates an array big enough where splitting is worthy, therefore the bit 4
`dont_split` is set to `False`
If a bigger array is created with this `typesize` the bit `dont_split` would be
set to false.
@coveralls
Copy link

coveralls commented Jun 20, 2017

Coverage Status

Coverage remained the same at 95.242% when pulling 090b133 on FrancescElies:cesc/fix-test into 3e30211 on Blosc:master.

@FrancescElies
Copy link
Member Author

Travis segmentation fault for py35, is this happening often? I triggered the job one more time

@esc esc merged commit 0584ee8 into Blosc:master Jun 23, 2017
@esc
Copy link
Member

esc commented Jun 23, 2017

Perfect!

@esc
Copy link
Member

esc commented Jun 23, 2017

Yeah, it segfaults occasionally on travis, apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants